From: Keir Fraser <keir@xensource.com>
To: "Woller, Thomas" <thomas.woller@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH][SVM] HVM fix for SWINT event injection
Date: Fri, 27 Jul 2007 16:57:15 +0100 [thread overview]
Message-ID: <C2CFD46B.13294%keir@xensource.com> (raw)
In-Reply-To: <683860AD674C7348A0BF0DE3918482F605801851@SAUSEXMB1.amd.com>
On 27/7/07 16:31, "Woller, Thomas" <thomas.woller@amd.com> wrote:
> Please apply to xen-unstable.
> Applies cleanly to c/s 15651.
> Signed-off-by Tom Woller <thomas.woller@amd.com>
The right thing to do here is copy the exitintinfo->eventinj only if
eventinj.fields.v==0. And to add a comment that in future the two events
should be 'merged' in the architecturally correct manner (e.g., turned into
#DF in some cases).
At least I *think* this is the right thing to do -- but now I think about
it, is it actually ever okay to copy a SWINT from exitintinfo into eventinj?
At the time the #PF vmexit happens, will EIP have been incremented across
the SWINT instruction? If not, does eventinj of a SWINT correctly cause EIP
to be incremented?
> Note that HVM guests will not boot on AMD-V with xen-staging.hg c/s
> 15652.
> Keir, do you want me to take a look at staging c/s 15652 on AMD-V w/
> HVM?
Yes please!
Thanks,
Keir
next prev parent reply other threads:[~2007-07-27 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 15:31 [PATCH][SVM] HVM fix for SWINT event injection Woller, Thomas
2007-07-27 15:57 ` Keir Fraser [this message]
2007-07-30 19:06 ` Woller, Thomas
2007-07-30 21:17 ` Keir Fraser
2007-07-31 15:30 ` Woller, Thomas
2007-07-31 18:02 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2CFD46B.13294%keir@xensource.com \
--to=keir@xensource.com \
--cc=thomas.woller@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.