Re: [PATCH] Fix xenmon/xentrace compile on Solaris

[Keir Fraser <keir@xensource.com>]

That's a lot of code to include verbatim in our repository, especially for
two non-essential build targets.

There are two potential better alternatives:
  1. Don't use argp at all in xentrace/xenmon -- do they really need
super-advanced argument parsing such that getopt will not suffice? As
low-level not-usually-user-visible daemons I would say that porting them to
getopt would be acceptable even if the command-line option syntax needs
changing a little to cleanly do so.
  2. Is libargp available separately from libc? If so you could require
users to install it if they wish to build xentrace/xenmon. Or you could
maintain the libargp you posted out-of-tree.

 -- Keir

On 7/8/07 14:14, "john.levon@sun.com" <john.levon@sun.com> wrote:

> # HG changeset patch
> # User john.levon@sun.com
> # Date 1186492378 25200
> # Node ID ae465d2d2b2ec9ab31598511fb35814ba6ab5602
> # Parent  1ddb3b21f4d8a6b449580ae45cf707f4b43198f9
> Fix xenmon/xentrace compile on Solaris
> 
> The argp interface is only present in GNU libc. Include a local copy when
> compiling on Solaris, and fix a couple of a trivial compile problems.
> 
> Signed-off-by: Tariq Magdon-Ismail <tariqmi@sun.com>