From: Keir Fraser <keir@xensource.com>
To: Stefan Berger <stefanb@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] [Xen] Check FADT's signature
Date: Fri, 10 Aug 2007 16:58:21 +0100 [thread overview]
Message-ID: <C2E249AD.14043%keir@xensource.com> (raw)
In-Reply-To: <OFFFC284DA.06E0EAA1-ON85257333.00553D26-85257333.00559D70@us.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1031 bytes --]
So the bug could be either that the read is getting hoisted above the
pagetable update (unlikely) or that there is a stale TLB entry (more
likely). You could discount the first possibility by replacing your
local_flush_tlb_pge() with mb() at the end of map_pages_to_xen(). If that
does not fix the bug then the problem is not that the read is getting
hoisted.
The TLB handling looks correct though ‹ if the modified PTE was not
previously empty then we execute an INVLPG on that virtual address. Might be
worth adding some tracing around there to see if the code thinks the PTE was
previously present, and hence whether the INVLPG actually gets executed?
-- Keir
On 10/8/07 16:35, "Stefan Berger" <stefanb@us.ibm.com> wrote:
> Keir Fraser <keir@xensource.com> wrote on 08/10/2007 11:09:43 AM:
>
>> > Not by my reading of the code, but your testing shows differently ;-)
>> >
>> > Have you tried adding tracing to map_pages_to_xen()? That¹s the guts
>> > of the remapping code.
>
> Now I did...
[-- Attachment #1.2: Type: text/html, Size: 1684 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2007-08-10 15:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 13:35 [PATCH] [Xen] Check FADT's signature Stefan Berger
2007-08-09 13:33 ` Keir Fraser
2007-08-09 17:54 ` Stefan Berger
2007-08-10 6:55 ` Keir Fraser
2007-08-10 11:36 ` Stefan Berger
2007-08-10 13:23 ` Keir Fraser
2007-08-10 8:51 ` Jan Beulich
2007-08-10 13:58 ` Stefan Berger
2007-08-10 15:09 ` Keir Fraser
2007-08-10 15:35 ` Stefan Berger
2007-08-10 15:58 ` Keir Fraser [this message]
2007-08-10 16:11 ` Stefan Berger
2007-08-10 16:15 ` Keir Fraser
2007-08-10 17:00 ` Stefan Berger
2007-08-10 18:21 ` Keir Fraser
2007-08-10 19:15 ` Keir Fraser
2007-08-24 6:19 ` Stefan Berger
2007-08-24 7:13 ` Jan Beulich
2007-08-24 15:04 ` Keir Fraser
2007-08-24 15:20 ` Keir Fraser
2007-08-27 10:50 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2E249AD.14043%keir@xensource.com \
--to=keir@xensource.com \
--cc=jbeulich@novell.com \
--cc=stefanb@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.