Re: [PATCH] [Xen] Check FADT's signature

[Keir Fraser <keir@xensource.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1156 bytes --]

You mean that local_flush_tlb_one() is NOT executed the first time we try to
map the FADT? That¹s obviously bogus, since we have mapped other ACPI tables
in that fixmap entry earlier during boot, and this is evidenced by the fact
that you can print out the current contents of that virtual address before
calling __acpi_map_table() and you do not fault (which you would if the PTE
did not have _PAGE_PRESENT set). So, now the investigation moves on to: WHY
does map_pages_to_xen() think that the PTE was not present, when it quite
obviously was??

I think we¹re getting somewhere, albeit rather slowly :-)

 -- Keir

On 10/8/07 17:11, "Stefan Berger" <stefanb@us.ibm.com> wrote:

>> > The TLB handling looks correct though ‹ if the modified PTE was not
>> > previously empty then we execute an INVLPG on that virtual address.
>> > Might be worth adding some tracing around there to see if the code
>> > thinks the PTE was previously present, and hence whether the INVLPG
>> > actually gets executed?
> 
> local_flush_tlb_one() does NOT get executed the first time, but upon the
> second attempt. 
> The mb() alone did NOT help.



[-- Attachment #1.2: Type: text/html, Size: 1864 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel