All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Erickson <gerickson@nuovations.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List
Date: Fri, 11 Apr 2008 13:36:04 -0700	[thread overview]
Message-ID: <C42519C4.E8EE%gerickson@nuovations.com> (raw)

When building against non-local, non-disk-backed file systems (e.g. NFS,
tmpfs), the u-boot build can iterate forever, attempting to re-generate
"include/autoconf.mk". This occurs because $(VERSION_FILE) (aka
${ROOT}/u-boot/build/include/version_autogenerated.h) is always regarded as
out-of-date because it is in the .PHONY target list, even though it's a real
file and seems to need to be only created once and only once.

This patch removes $(VERSION_FILE) from the .PHONY target list and has been
verified to work with various flavors and builds of make-3.81 against NFS,
ext2fs, ext3fs and tmpfs file systems.

More detail at:

http://sourceforge.net/mailarchive/message.php?msg_id=C4180895.E556%25gerick
son%40nuovations.com

Signed-off-by: Grant Erickson <gerickson@nuovations.com>

---
diff --git a/Makefile b/Makefile
index e5b4210..50069b7 100644
--- a/Makefile
+++ b/Makefile
@@ -247,7 +247,7
 LIBS += api/libapi.a
 
 LIBS := $(addprefix $(obj),$(LIBS))
-.PHONY : $(LIBS) $(VERSION_FILE)
+.PHONY : $(LIBS)
 
 # Add GCC lib
 PLATFORM_LIBS += -L $(shell dirname `$(CC) $(CFLAGS)
-print-libgcc-file-name`) -lgcc

             reply	other threads:[~2008-04-11 20:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 20:36 Grant Erickson [this message]
2008-04-12 19:29 ` [U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List Mike Frysinger
2008-04-13  6:20   ` Grant Erickson
2008-04-13  6:43     ` Mike Frysinger
2008-05-09  8:22 ` Wolfgang Denk
2008-05-09 16:00   ` Grant Erickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C42519C4.E8EE%gerickson@nuovations.com \
    --to=gerickson@nuovations.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.