[U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List

[Grant Erickson <gerickson@nuovations.com>]

On 5/9/08 1:22 AM, Wolfgang Denk wrote:
> In message <C42519C4.E8EE%gerickson@nuovations.com> you wrote:
>> When building against non-local, non-disk-backed file systems (e.g. NFS,
>> tmpfs), the u-boot build can iterate forever, attempting to re-generate
>> "include/autoconf.mk". This occurs because $(VERSION_FILE) (aka
>> ${ROOT}/u-boot/build/include/version_autogenerated.h) is always regarded as
>> out-of-date because it is in the .PHONY target list, even though it's a real
>> file and seems to need to be only created once and only once.
>> 
>> This patch removes $(VERSION_FILE) from the .PHONY target list and has been
>> verified to work with various flavors and builds of make-3.81 against NFS,
>> ext2fs, ext3fs and tmpfs file systems.
>> 
>> More detail at:
>> 
>> http://sourceforge.net/mailarchive/message.php?msg_id=C4180895.E556%25gerick
>> son%40nuovations.com
> 
> This may fix your immediate problem, but it is wrong. Assume you have
> built U-Boot from some specific version, then the git commit ID  will
> be  shown  as  part of the version string. Assume you now edit a file
> and run "make" again. The intention is that this new build shows  the
> "-dirty" marker in the version string, plus the new build date.
> 
> Your change breaks this behaviour.
> 
> I just  posted  another  patch:  ``Avoid  infinite  loop  "Generating
> include/autoconf.mk" '' which is supposed to fix the problem, without
> unwanted side effects.
> 
> Please test.

Wolfgang,

This patch works effectively and successfully when tested against NFSv3,
EXT2, EXT3 and TMPFS file systems with make v3.79, v.3.80 and v3.81.

Thanks,

Grant