[PATCH]ioemu-remote&ioemu: Fix unmapping issue on hot-removing.

[PATCH]ioemu-remote&ioemu: Fix unmapping issue on hot-removing.

[Yuji Shimada]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

This patch fixes unmapping issue on hot-removing.
I believe my patch and Cui's patch together fix bug #1316 .

> 1. hot-plug attaching VT-d NIC to guest failed.
> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1316.


After applying this patch, following messages will disappear.

qemu-dm's message:
pt_unregister_regions: Error: remove old io mapping failed!

Hypervisor's messages:
(XEN) p2m.c:1172:d0 clear_mmio_p2m_entry: gfn_to_mfn failed! gfn=000fffff
(XEN) domctl.c:820:d0 ioport_map:invalid:gport=ffffffff mport=3000 nr_ports=40

Thanks,

Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp>

--
Yuji Shimada

On Tue, 19 Aug 2008 00:26:08 +0800
"Cui, Dexuan" <dexuan.cui@intel.com> wrote:

> > On PAE, failed to hotplug attach USB EHCI device to Linux guest.
> > http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1318
> > 
> > UHCI hotplug can not work on Montevina platform.
> > http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1319
> 
> With the attached patch, these 2 bugs would be gone.
> 
> Thanks,
> -- Dexuan

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_unmapping_issue.patch --]
[-- Type: text/x-patch; name="fix_unmapping_issue.patch", Size: 495 bytes --]

diff --git a/hw/pass-through.c b/hw/pass-through.c
index 7b46234..a42bb20 100644
--- a/hw/pass-through.c
+++ b/hw/pass-through.c
@@ -1424,6 +1424,10 @@ static void pt_unregister_regions(struct pt_dev *assigned_device)
         if ( e_size == 0 )
             continue;
 
+        /* avoid unmapping for invalid physbase */
+        if ( assigned_device->bases[i].e_physbase == -1 )
+            continue;
+
         type = d->io_regions[i].type;
 
         if ( type == PCI_ADDRESS_SPACE_MEM ||

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH]ioemu-remote&ioemu: Fix unmapping issue on hot-removing.

[Yuji Shimada]

The patch I had sent was applied to xen-unstable.hg (18344: 0cf244daf3c4).

I'd like you to apply the patch to ioemu-remote too.

--
Yuji Shimada

Re: [PATCH]ioemu-remote&ioemu: Fix unmapping issue on hot-removing.

[Keir Fraser]

It already has been.

 -- Keir

On 21/8/08 02:25, "Yuji Shimada" <shimada-yxb@necst.nec.co.jp> wrote:

> The patch I had sent was applied to xen-unstable.hg (18344: 0cf244daf3c4).
> 
> I'd like you to apply the patch to ioemu-remote too.
> 
> --
> Yuji Shimada
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel