From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Wei, Gang" <gang.wei@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intr while force hpetbroadcast
Date: Wed, 10 Sep 2008 11:15:42 +0100 [thread overview]
Message-ID: <C4ED5CDE.26F1B%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <8FED46E8A9CA574792FC7AACAC38FE7701ACA5C4B4@PDSMSX501.ccr.corp.intel.com>
On 9/9/08 09:28, "Wei, Gang" <gang.wei@intel.com> wrote:
>> From above sequences, we can find this case will either introduce extra HPET
>> intrs or put off the softtimer expiring.
> This patch simply stops the LAPIC timer first (avoid immediate unnecessary
> expiring) and raise a softirq (continue the softtimer handling process, which
> will correct the LAPIC timer) when reprogram LAPIC timer fails.
It's not clear to me the disable/enable_LAPIC_timer() work is worthwhile for
the few timer interrupts it is likely to avoid. The other bit of the patch
is a good bugfix though. I've taken just the latter part.
-- Keir
next prev parent reply other threads:[~2008-09-10 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 8:28 [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intr while force hpetbroadcast Wei, Gang
2008-09-10 10:15 ` Keir Fraser [this message]
2008-09-10 14:25 ` Wei, Gang
2008-09-10 14:51 ` [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intrwhile " Tian, Kevin
2008-09-11 7:38 ` [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intr while " Keir Fraser
2008-09-11 7:46 ` Wei, Gang
2008-09-11 10:38 ` Keir Fraser
2008-09-11 10:59 ` [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timerintr " Tian, Kevin
2008-09-11 11:06 ` Keir Fraser
2008-09-11 15:22 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4ED5CDE.26F1B%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=gang.wei@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.