From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Xen Developers <xen-devel@lists.xensource.com>
Subject: Re: several Qs about domain live migration
Date: Tue, 18 Nov 2008 09:12:19 +0000 [thread overview]
Message-ID: <C5483773.1F518%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <49227B56.4090602@intel.com>
On 18/11/08 08:22, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:
>> Try changing gmfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e)) in mod_l1_entry()
>> to:
>> mfn = gfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e), &p2mt);
>> if ( !p2m_is_ram(p2mt) || (mfn == INVALID_MFN) )
>> ....
>>
>> This will prevent foreign mappings of 'mmio' pages. Pretty sensible and will
>> fix this problem.
>>
>
> It's great!
> Does p2m_is_ram return 1 for video memory?
Yes, since it is just ordinary guest memory. That was the point of Samuel's
patch.
-- Keir
> I'll make a small patch and test it.
next prev parent reply other threads:[~2008-11-18 9:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 6:50 several Qs about domain live migration Tian, Kevin
2008-11-17 7:45 ` Keir Fraser
2008-11-17 7:49 ` Tian, Kevin
2008-11-17 8:40 ` Keir Fraser
2008-11-17 8:46 ` Tian, Kevin
2008-11-18 1:17 ` Zhai, Edwin
2008-11-18 8:13 ` Keir Fraser
2008-11-18 8:22 ` Zhai, Edwin
2008-11-18 9:12 ` Keir Fraser [this message]
2008-11-18 9:35 ` Zhai, Edwin
2008-11-18 9:47 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5483773.1F518%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=edwin.zhai@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.