From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Adjust time init sequence
Date: Thu, 11 Dec 2008 00:44:44 +0000 [thread overview]
Message-ID: <C56612FC.2011A%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <0A882F4D99BBF6449D58E61AAFD7EDD603BB491E@pdsmsx502.ccr.corp.intel.com>
On 11/12/2008 00:23, "Tian, Kevin" <kevin.tian@intel.com> wrote:
>> Is it really safe to use NOW() before init_percpu_time()? Seems dodgy.
>
> Where did you mean by using NOW before init_percpu_time?
> I moved do_settime earlier but with a zero system stamp now
> which matches the line behind to init stime_platform_time to zero.
> To me there's no difference to initialize wallclock at zero point
> or sometime after with a NOW() drift, which should cause similar
> result to wc_sec/wc_nsec.
init_platform_time() -> plt_overflow() -> NOW()
Perhaps the above is safe though? Will NOW() return zero for an
uninitialised per-cpu time sstructure (since stime_local_stamp and tsc_scale
are both zero)?
-- Keir
next prev parent reply other threads:[~2008-12-11 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 13:10 [PATCH] Adjust time init sequence Tian, Kevin
2008-12-10 13:49 ` Keir Fraser
2008-12-11 0:23 ` Tian, Kevin
2008-12-11 0:44 ` Keir Fraser [this message]
2008-12-11 0:47 ` Tian, Kevin
2008-12-11 4:45 ` Tian, Kevin
2008-12-11 9:04 ` Keir Fraser
2008-12-11 9:06 ` Tian, Kevin
2008-12-11 13:12 ` Keir Fraser
2008-12-12 3:40 ` Tian, Kevin
2008-12-12 9:08 ` Keir Fraser
2008-12-12 10:10 ` Jan Beulich
2008-12-12 10:38 ` Keir Fraser
2008-12-12 16:40 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C56612FC.2011A%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.