From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Adjust time init sequence
Date: Fri, 12 Dec 2008 09:08:30 +0000 [thread overview]
Message-ID: <C567DA8E.20258%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <0A882F4D99BBF6449D58E61AAFD7EDD603BB493B@pdsmsx502.ccr.corp.intel.com>
On 12/12/2008 03:40, "Tian, Kevin" <kevin.tian@intel.com> wrote:
> A temp workaround is to move rdtscll(t->local_tsc_stamp) into
> calibrate_tsc_bp, which gives a sane NOW() before percpu time
> init. But then the purpose behind is ambiguous... why would we
> want to count system time from this point? If we can't count
> system time starting from power on, it looks clearer to tag system
> time as 0 when initializing wc_sec/wc_nsec by do_settime.
> Actually the starting point of xen system time is not that critical
> since it's mostly used by relative progress. Then my previous
> updated patch can be used? :-)
How about rdtscll(t->local_tsc_stamp) at the top of init_xen_time(), and
remove the one I added to early_time_init()? That would allow NOW() usage at
least in init_xen_time(), and be later than the TSC reset.
-- Keir
next prev parent reply other threads:[~2008-12-12 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 13:10 [PATCH] Adjust time init sequence Tian, Kevin
2008-12-10 13:49 ` Keir Fraser
2008-12-11 0:23 ` Tian, Kevin
2008-12-11 0:44 ` Keir Fraser
2008-12-11 0:47 ` Tian, Kevin
2008-12-11 4:45 ` Tian, Kevin
2008-12-11 9:04 ` Keir Fraser
2008-12-11 9:06 ` Tian, Kevin
2008-12-11 13:12 ` Keir Fraser
2008-12-12 3:40 ` Tian, Kevin
2008-12-12 9:08 ` Keir Fraser [this message]
2008-12-12 10:10 ` Jan Beulich
2008-12-12 10:38 ` Keir Fraser
2008-12-12 16:40 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C567DA8E.20258%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.