Re: [PATCH] fs-backend: fix compile problems

[Keir Fraser <keir.fraser@eu.citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 6914 bytes --]

Just fixed this one in cs 19388.

 -- Keir

On 18/03/2009 16:13, "Boris Derzhavets" <bderzhavets@yahoo.com> wrote:

> The most recent Xen Unstable installed:-
> make xen OK
> make install-xen OK
> make tools 
> 
> 
> gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
> -Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_restore.o.d
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
> -I../../xen/common/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore
> -I../include -c -o xc_domain_restore.o xc_domain_restore.c
> gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
> -Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_save.o.d
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
> -I../../xen/common/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore
> -I../include -c -o xc_domain_save.o xc_domain_save.c
> cc1: warnings being treated as errors
> xc_domain_save.c: In function Œlock_suspend_event¹:
> xc_domain_save.c:764: error: ignoring return value of Œwrite¹, declared with
> attribute warn_unused_result
> make[4]: *** [xc_domain_save.o] Error 1
> make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc'
> make[3]: *** [build] Error 2
> make[3]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc'
> make[2]: *** [subdir-install-libxc] Error 2
> make[2]: Leaving directory `/usr/src/xen-unstable.hg/tools'
> make[1]: *** [subdirs-install] Error 2
> make[1]: Leaving directory `/usr/src/xen-unstable.hg/tools'
> make: *** [install-tools] Error 2
> 
> I belive requires same patch as fs-backend.c
> 
> 
> Boris
> 
> 
> 
> --- On Wed, 3/18/09, Keir Fraser <keir.fraser@eu.citrix.com> wrote:
>> From: Keir Fraser <keir.fraser@eu.citrix.com>
>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
>> To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>, "Stefano Stabellini"
>> <Stefano.Stabellini@eu.citrix.com>
>> Cc: "xen-devel" <xen-devel@lists.xensource.com>
>> Date: Wednesday, March 18, 2009, 11:00 AM
>> 
>> Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to latest
>> xen-unstable. It¹s fixed there.
>> 
>>  -- Keir
>> 
>> On 18/03/2009 14:53, "Boris Derzhavets" <bderzhavets@yahoo.com> wrote:
>> 
>>> Now "make install-xen" fails :-
>>> 
>>> make[6]: Entering directory
>>> `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck'
>>> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
>>> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
>>> -Wdeclaration-after-statement  -nostdinc -fno-builtin -fno-common
>>> -iwithprefix include -Werror -Wno-pointer-arith -pipe
>>> -I/usr/src/xen-unstable.hg/xen/include
>>> -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic
>>> -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float
>>> -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks
>>> -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__
>>> -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF
>>> .mce_intel.o.d -c mce_intel.c -o mce_intel.o
>>> mce_intel.c:17: error: static declaration of Œfirstbank¹ follows non-static
>>> declaration
>>> x86_mca.h:95: error: previous declaration of Œfirstbank¹ was here
>>> make[6]: *** [mce_intel.o] Error 1
>>> make[6]: Leaving directory
>>> `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck'
>>> make[5]: *** [mcheck/built_in.o] Error 2
>>> make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu'
>>> make[4]: *** [cpu/built_in.o] Error 2
>>> make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
>>> make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
>>> make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
>>> make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2
>>> make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen'
>>> make[1]: *** [install] Error 2
>>> make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen'
>>> make: *** [install-xen] Error 2
>>> 
>>> 
>>> --- On Wed, 3/18/09, Boris Derzhavets <bderzhavets@yahoo.com> wrote:
>>>> From: Boris Derzhavets <bderzhavets@yahoo.com>
>>>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
>>>> To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
>>>> Cc: "xen-devel" <xen-devel@lists.xensource.com>
>>>> Date: Wednesday, March 18, 2009, 10:48 AM
>>>> 
>>>> Thank you. It's done
>>>> Boris
>>>> 
>>>> --- On Wed, 3/18/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>> wrote:
>>>>> From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
>>>>> To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
>>>>> Cc: "xen-devel" <xen-devel@lists.xensource.com>
>>>>> Date: Wednesday, March 18, 2009, 10:19 AM
>>>>> 
>>>>> Boris Derzhavets wrote:
>>>>> 
>>>>>> > Removed unresolved reference in
>>>>>> > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference
>>>>>> > to `pci_emulation_add'
>>>>>> > 
>>>>>> > /*    for (i = 0; i < nb_pci_emulation; i++) {
>>>>>> >         if(pci_emulation_add(pci_emulation_config_text[i]) < 0)
>>>>>  {
>>>>>> >             fprintf(stderr, "Warning: could not add PCI device
>>>>> %s\n",
>>>>>> >                     pci_emulation_config_text[i]);
>>>>>> >         }
>>>>>> >     }
>>>>>> > */
>>>>>> > 
>>>>>> > "make tools" completed OK.
>>>>>> > Is it acceptable ?
>>>>>> > 
>>>>> 
>>>>> 
>>>>> 
>>>>> I think we are missing an ifdef
>>>>>  CONFIG_PASSTHROUGH
>>>>> 
>>>>> 
>>>>> diff --git a/vl.c b/vl.c
>>>>> index 9b9f7d5..6c0ffb3 100644
>>>>> --- a/vl.c
>>>>> +++ b/vl.c
>>>>> @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
>>>>>          }
>>>>>      }
>>>>>  
>>>>> +#ifdef CONFIG_PASSTHROUGH
>>>>>      for (i = 0; i < nb_pci_emulation; i++) {
>>>>>          if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {
>>>>>              fprintf(stderr, "Warning: could not add PCI device
>>>>> %s\n",
>>>>>                      pci_emulation_config_text[i]);
>>>>>          }
>>>>>      }
>>>>> +#endif
>>>>>  
>>>>>      if (strlen(direct_pci_str) > 0)
>>>>>          direct_pci =
>>>>>  direct_pci_str;
>>>>> 
>>>>> _______________________________________________
>>>>> Xen-devel mailing list
>>>>> Xen-devel@lists.xensource.com
>>>>> http://lists.xensource.com/xen-devel
>>>> 
>>>>  
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@lists.xensource.com
>>>> http://lists.xensource.com/xen-devel
>>> 
>>>  
>>  
> 
>  


[-- Attachment #1.2: Type: text/html, Size: 9997 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel