All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Isaku Yamahata <yamahata@valinux.co.jp>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Subject: Re: Dom0 crashing when built with c/s 881 (Was: blktap2: need more than 3 values to unpack)
Date: Wed, 03 Jun 2009 22:27:33 +0100	[thread overview]
Message-ID: <C64CA955.CAF1%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <c54eb33a-47cc-494e-a5ab-2d0bdb825b41@default>

On 03/06/2009 22:17, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:

>>  1. It only adds extra functionality which by default would
>> not do anything.
>> Just reading the patch I can see it's harmless by itself as it merely
>> introduces a new notifier chain which noone registers on.
> 
> I won't pretend to understand the code, but I did
> reproduce the problem with 881 by itself and with
> 889 with 881 reverted.

I can't explain that from reading the code. It looks like a no-op to me
unless the new function bus_register_notifier() is called.

>>  2. Changeset 882 depends on 881. If you revert just 881 then
>> the tree will not build.
> 
> This doesn't appear to be the case for me, though
> I'm certainly willing to believe there's something
> wrong with my process:

Actually I missed that the dependent code is only built if
CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got one or both
disabled and hence 882 doesn't break without 881 in your case.

 -- Keir

  reply	other threads:[~2009-06-03 21:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.GSO.4.60.0906020756360.23746@cascade.cs.ubc.ca>
2009-06-02 17:33 ` blktap2: need more than 3 values to unpack Dan Magenheimer
2009-06-02 22:44   ` Keir Fraser
2009-06-02 23:49     ` Dan Magenheimer
2009-06-03  4:45       ` Dan Magenheimer
2009-06-03 17:35         ` Dom0 crashing when built with c/s 881 (Was: blktap2: need more than 3 values to unpack) Dan Magenheimer
2009-06-03 17:48           ` Keir Fraser
2009-06-03 17:57             ` Dulloor
2009-06-03 18:45               ` Keir Fraser
2009-06-03 20:15                 ` Dan Magenheimer
2009-06-03 20:46                   ` Keir Fraser
2009-06-03 21:17                     ` Dan Magenheimer
2009-06-03 21:27                       ` Keir Fraser [this message]
2009-06-03 22:12                         ` Dan Magenheimer
2009-06-04  1:09                           ` Dan Magenheimer
2009-06-04  4:49                             ` Dan Magenheimer
2009-06-04  7:34                               ` Keir Fraser
2009-06-04 16:11                                 ` Dan Magenheimer
2009-06-04  4:18                           ` Isaku Yamahata
2009-06-04  4:30                             ` Isaku Yamahata
2009-06-04  4:13                 ` Isaku Yamahata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C64CA955.CAF1%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.