From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
Isaku Yamahata <yamahata@valinux.co.jp>
Cc: "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Subject: RE: Dom0 crashing when built with c/s 881 (Was: blktap2: need more than 3 values to unpack)
Date: Thu, 4 Jun 2009 09:11:57 -0700 (PDT) [thread overview]
Message-ID: <cde9ddd7-61b5-4f03-976c-33910ab2ee7f@default> (raw)
In-Reply-To: <C64D377F.CB99%keir.fraser@eu.citrix.com>
Yes indeed. I added some code to reset the
fields incorrectly containing "nousb" to their
expected value of 0, and the dom0 kernel still fails
to boot. So this is likely just a symptom of broader
memory corruption.
> -----Original Message-----
> From: Keir Fraser [mailto:keir.fraser@eu.citrix.com]
> Sent: Thursday, June 04, 2009 1:34 AM
> To: Dan Magenheimer; Isaku Yamahata
> Cc: Xen-Devel (E-mail)
> Subject: Re: Dom0 crashing when built with c/s 881 (Was: [Xen-devel]
> blktap2: need more than 3 values to unpack)
>
>
> If memory corruption is the issue, c/s 881 could be
> innocently triggering a
> latent bug.
>
> -- Keir
>
> On 04/06/2009 05:49, "Dan Magenheimer"
> <dan.magenheimer@oracle.com> wrote:
>
> > I'm quitting for the night now, but I see that
> > the string "nous" is followed by a "b" in the
> > immediately following word. Put this together
> > and you have "nousb" (read as turn off USB).
> >
> > Given that the "Driver 'xxx' needs updating"
> > are for 'usbfs', 'hub', and 'usb', and given
> > that usb is very related to hotplug, the string
> > "nousb" where a pair of function pointers should
> > be is suspicious (though it may also be a complete
> > coincidence).
> >
> > I'll try turning off CONFIG_HOTPLUG_PCI tomorrow.
> >
> > Dan
> >
> >> -----Original Message-----
> >> From: Dan Magenheimer
> >> Sent: Wednesday, June 03, 2009 7:09 PM
> >> To: Keir Fraser; Isaku Yamahata
> >> Cc: Xen-Devel (E-mail)
> >> Subject: RE: Dom0 crashing when built with c/s 881 (Was:
> [Xen-devel]
> >> blktap2: need more than 3 values to unpack)
> >>
> >>
> >>> If that doesn't help, I can go add some printk's where that
> >>> output is happening and see exactly what forces the failure.
> >>
> >> Here's what I am seeing. Looks like the drv->bus structure
> >> is getting overwritten with ASCII.
> >>
> >> Driver 'usbfs' needs updating - please use bus_type methods
> >> drv->bus->probe = 73756f6e (THAT's "nous" I think)
> >> drv->probe = d1069ab0
> >> drv->bus->remove = 00000062
> >> drv->remove = d1069960
> >> drv->bus->shutdown = 00000000
> >> drv->shutdown = 00000000
> >> usbcore: registered new driver usbfs
> >> Driver 'hub' needs updating - please use bus_type methods
> >> drv->bus->probe = 73756f6e
> >> drv->probe = d1069ab0
> >> drv->bus->remove = 00000062
> >> drv->remove = d1069960
> >> drv->bus->shutdown = 00000000
> >> drv->shutdown = 00000000
> >> usbcore: registered new driver hub
> >> Driver 'usb' needs updating - please use bus_type methods
> >> drv->bus->probe = 73756f6e
> >> drv->probe = d1069570
> >>
> >>> -----Original Message-----
> >>> From: Dan Magenheimer
> >>> Sent: Wednesday, June 03, 2009 4:12 PM
> >>> To: Keir Fraser; Isaku Yamahata
> >>> Cc: Xen-Devel (E-mail)
> >>> Subject: RE: Dom0 crashing when built with c/s 881 (Was:
> [Xen-devel]
> >>> blktap2: need more than 3 values to unpack)
> >>>
> >>>
> >>>> Actually I missed that the dependent code is only built if
> >>>> CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got
> >>>> one or both
> >>>> disabled and hence 882 doesn't break without 881 in your case.
> >>>
> >>> In case it helps, with 889 and 881 reverted, I am using the
> >>> default config which results in CONFIG_PCI_IOMULTI=y and
> >>> CONFIG_HOTPLUG_PCI=m.
> >>>
> >>>> I can't explain that from reading the code. It looks like a
> >>>> no-op to me
> >>>> unless the new function bus_register_notifier() is called.
> >>>
> >>> Looking at my boot output on failure, there are those lines:
> >>>
> >>> "Driver 'xxx' needs updating - please use bus_type methods"
> >>>
> >>> which is printed in linux/drivers/base/driver.c:driver_register()
> >>> if a complex set of circumstances are true. So clearly
> >>> something is different.
> >>>
> >>> If that doesn't help, I can go add some printk's where that
> >>> output is happening and see exactly what forces the failure.
> >>>
> >>> Dan
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Keir Fraser [mailto:keir.fraser@eu.citrix.com]
> >>>> Sent: Wednesday, June 03, 2009 3:28 PM
> >>>> To: Dan Magenheimer; Isaku Yamahata
> >>>> Cc: Xen-Devel (E-mail)
> >>>> Subject: Re: Dom0 crashing when built with c/s 881 (Was:
> >> [Xen-devel]
> >>>> blktap2: need more than 3 values to unpack)
> >>>>
> >>>>
> >>>> On 03/06/2009 22:17, "Dan Magenheimer"
> >>>> <dan.magenheimer@oracle.com> wrote:
> >>>>
> >>>>>> 1. It only adds extra functionality which by default would
> >>>>>> not do anything.
> >>>>>> Just reading the patch I can see it's harmless by itself
> >>>> as it merely
> >>>>>> introduces a new notifier chain which noone registers on.
> >>>>>
> >>>>> I won't pretend to understand the code, but I did
> >>>>> reproduce the problem with 881 by itself and with
> >>>>> 889 with 881 reverted.
> >>>>
> >>>> I can't explain that from reading the code. It looks like a
> >>>> no-op to me
> >>>> unless the new function bus_register_notifier() is called.
> >>>>
> >>>>>> 2. Changeset 882 depends on 881. If you revert just 881 then
> >>>>>> the tree will not build.
> >>>>>
> >>>>> This doesn't appear to be the case for me, though
> >>>>> I'm certainly willing to believe there's something
> >>>>> wrong with my process:
> >>>>
> >>>> Actually I missed that the dependent code is only built if
> >>>> CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got
> >>>> one or both
> >>>> disabled and hence 882 doesn't break without 881 in your case.
> >>>>
> >>>> -- Keir
> >>>>
> >>>>
> >>>>
>
>
>
next prev parent reply other threads:[~2009-06-04 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.GSO.4.60.0906020756360.23746@cascade.cs.ubc.ca>
2009-06-02 17:33 ` blktap2: need more than 3 values to unpack Dan Magenheimer
2009-06-02 22:44 ` Keir Fraser
2009-06-02 23:49 ` Dan Magenheimer
2009-06-03 4:45 ` Dan Magenheimer
2009-06-03 17:35 ` Dom0 crashing when built with c/s 881 (Was: blktap2: need more than 3 values to unpack) Dan Magenheimer
2009-06-03 17:48 ` Keir Fraser
2009-06-03 17:57 ` Dulloor
2009-06-03 18:45 ` Keir Fraser
2009-06-03 20:15 ` Dan Magenheimer
2009-06-03 20:46 ` Keir Fraser
2009-06-03 21:17 ` Dan Magenheimer
2009-06-03 21:27 ` Keir Fraser
2009-06-03 22:12 ` Dan Magenheimer
2009-06-04 1:09 ` Dan Magenheimer
2009-06-04 4:49 ` Dan Magenheimer
2009-06-04 7:34 ` Keir Fraser
2009-06-04 16:11 ` Dan Magenheimer [this message]
2009-06-04 4:18 ` Isaku Yamahata
2009-06-04 4:30 ` Isaku Yamahata
2009-06-04 4:13 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde9ddd7-61b5-4f03-976c-33910ab2ee7f@default \
--to=dan.magenheimer@oracle.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.