All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] [SVM]: Make 32bit legacy guests boot again
Date: Sat, 27 Jun 2009 10:35:20 +0100	[thread overview]
Message-ID: <C66BA668.E4B9%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <200906261719.55259.Christoph.Egger@amd.com>

Changeset 19856 is a cleaned up and streamlined version of this patch.
Please take a look. It also fixes a couple of largely theoretical issues:
 * Should depend on EFER.LMA not EFER.LME
 * Should handle the LMA 1->0 transition (i.e., return to legacy mode).

 -- Keir

On 26/06/2009 16:19, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> 
> Hi!
> 
> Attached patch fixes a bug introduced in c/s 19648.
> 
> 32bit legacy guests have the sysenter/sysexit instructions available.
> Therefore, we have to disable intercepts for the sysenter MSRs or the
> guest stucks in an infinite loop of #GPs, otherwise.
> 
> For guests in 64bit mode and 32bit compat mode, sysenter/sysexit instructions
> aren't available. The sysenter MSRs have to be intercepted to make the
> instruction emulation working.
> 
> Attach patch first assumes the guest is in 32bit legacy mode and therefore
> disables the sysenter MSRs in construct_vmcb().
> Access to the MSR_EFER is intercepted. When the guest enables longmode,
> then enable interception of the sysenter MSRs.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> 

  reply	other threads:[~2009-06-27  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26 15:19 [PATCH] [SVM]: Make 32bit legacy guests boot again Christoph Egger
2009-06-27  9:35 ` Keir Fraser [this message]
2009-06-29  8:39   ` Christoph Egger
2009-06-29  9:17     ` Keir Fraser
2009-06-29 11:36       ` Christoph Egger
2009-06-29 14:51         ` Keir Fraser
2009-06-29 16:01           ` Christoph Egger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C66BA668.E4B9%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=Christoph.Egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.