All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Kieran Mansley <kmansley@solarflare.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: xen_tlb_flush_all mfn validation panic
Date: Thu, 24 Dec 2009 16:01:09 +0000	[thread overview]
Message-ID: <C75940C5.5338%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <C75939F9.5334%keir.fraser@eu.citrix.com>

On 24/12/2009 15:32, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> On 24/12/2009 15:06, "Kieran Mansley" <kmansley@solarflare.com> wrote:
> 
>> The initial "bad gmfn" message seems to be due to an attempt to validate
>> the mfn argument to the mmuext_op.  It's not surprising to me that this
>> fails as xen_tlb_flush_all doesn't supply an mfn argument - it's not
>> needed for the MMUEXT_TLB_FLUSH_ALL command.  Is there something that is
>> supposed to mean that the mfn argument should be valid even when not
>> explicitly set by the caller, or is the validation of the mfn for all
>> mmuext_op commands a bug?
> 
> The explicit check for INVALID_MFN is new, and that is obviously a bug. I
> will sort out a suitable fix for this.

Should be fixed by c/s 20723.

 -- Keir

  reply	other threads:[~2009-12-24 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-24 15:06 xen_tlb_flush_all mfn validation panic Kieran Mansley
2009-12-24 15:32 ` Keir Fraser
2009-12-24 16:01   ` Keir Fraser [this message]
2009-12-24 16:13     ` Kieran Mansley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C75940C5.5338%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=kmansley@solarflare.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.