All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Wei Wang2 <wei.wang2@amd.com>, "Kay, Allen M" <allen.m.kay@intel.com>
Cc: Tim Deegan <Tim.Deegan@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 4/4] amd iommu: Large io page support - implementation
Date: Tue, 07 Dec 2010 18:00:45 +0000	[thread overview]
Message-ID: <C92426CD.BDEE%keir@xen.org> (raw)
In-Reply-To: <201012071220.03624.wei.wang2@amd.com>


Cc'ing Tim -- he could advise how plausible it is to find other available
bits to move the p2m types to. Also I'm not sure whether the p2m tables ever
get used as host pagetables these days (e.g., when guest has CR0.PG=0). That
could affect how difficult it is to mess with the p2m format.

If it's possible, though, it's probably worth pursuing. Sharing the tables
uses less memory, and could be less complicated code too.

 -- Keir

On 07/12/2010 11:20, "Wei Wang2" <wei.wang2@amd.com> wrote:

> Hi Allen,
> Actually, each amd iommu pde entry uses bit 9-11 to encode next page table
> level, but these bits are also used as AVL bits by p2m table to encode
> different page types...So, it might not be quite easy to share NPT table with
> amd iommu unless we change p2m table encoding for this first.
> Thanks,
> Wei
> 
> On Tuesday 07 December 2010 01:47:22 Kay, Allen M wrote:
>> Hi Wei,
>> 
>> My understanding is that both EPT/NPT already supports 2M and 1G page
>> sizes.  If this is true and if NPT supports the same page table format as
>> AMD iommu, shouldn't iommu 2M and 1G support just a matter of pointing
>> iommu page table pointer to NPT page table of the same guest OS thus
>> sharing the same page table between NPT and AMD iommu?
>> 
>> This should save a lot code changes in iommu code.  We just need to flush
>> iommu page table in IOTLB at appropriate places.
>> 
>> Allen
>> 
>> -----Original Message-----
>> From: xen-devel-bounces@lists.xensource.com
>> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Wei Wang2 Sent:
>> Friday, December 03, 2010 8:04 AM
>> To: xen-devel@lists.xensource.com
>> Subject: [Xen-devel] [PATCH 4/4] amd iommu: Large io page support -
>> implementation
>> 
>> This is the implementation.
>> 
>> Thanks,
>> We
>> Signed-off-by: Wei Wang <wei.wang2@amd.com>
>> --
>> Legal Information:
>> Advanced Micro Devices GmbH
>> Sitz: Dornach, Gemeinde Aschheim,
>> Landkreis München Registergericht München, HRB Nr. 43632
>> Geschäftsführer:
>> Alberto Bozzo, Andrew Bowd
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  reply	other threads:[~2010-12-07 18:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 16:03 [PATCH 4/4] amd iommu: Large io page support - implementation Wei Wang2
2010-12-07  0:47 ` Kay, Allen M
2010-12-07 11:20   ` Wei Wang2
2010-12-07 18:00     ` Keir Fraser [this message]
2010-12-07 18:21       ` Kay, Allen M
2010-12-08 10:03       ` Tim Deegan
2010-12-08 13:02         ` Wei Wang2
2010-12-08 13:11           ` Tim Deegan
2010-12-08 18:38             ` [RFC][PATCH][VTD] EPT/VT-d page table sharing Kay, Allen M
2010-12-09 10:12               ` Tim Deegan
2010-12-11  2:01                 ` Kay, Allen M
2010-12-21 17:08                   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C92426CD.BDEE%keir@xen.org \
    --to=keir@xen.org \
    --cc=Tim.Deegan@eu.citrix.com \
    --cc=allen.m.kay@intel.com \
    --cc=wei.wang2@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.