From: Keir Fraser <keir.xen@gmail.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
Jan Beulich <JBeulich@novell.com>
Cc: xen-devel@lists.xensource.com,
"winston.l.wang" <winston.l.wang@intel.com>
Subject: Re: [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits
Date: Fri, 15 Apr 2011 07:40:00 +0100 [thread overview]
Message-ID: <C9CDA6D0.16614%keir.xen@gmail.com> (raw)
In-Reply-To: <7a5514b0-b3d6-478a-9434-b80758a7445d@default>
On 14/04/2011 23:41, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:
>> Yeah, if we want to continue to try avoiding write_tsc() on
>> TSC_RELIABLE
>> then we should assert !TSC_RELIABLE on the write_tsc() path in
>> cstate_tsc_restore().
>
> Agreed. In fact, maybe it should be asserted in write_tsc?
We still write_tsc on CPU physical hot-add.
-- Keir
next prev parent reply other threads:[~2011-04-15 6:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 7:18 [PATCH] x86: don't write_tsc() non-zero values on CPUs updating only the lower 32 bits Jan Beulich
2011-04-14 7:25 ` Keir Fraser
2011-04-14 7:42 ` Jan Beulich
2011-04-14 7:50 ` Keir Fraser
2011-04-14 8:06 ` Jan Beulich
2011-04-14 9:18 ` Keir Fraser
2011-04-14 22:41 ` Dan Magenheimer
2011-04-15 6:40 ` Keir Fraser [this message]
2011-04-15 14:34 ` Dan Magenheimer
2011-04-15 17:28 ` Keir Fraser
2011-04-14 7:28 ` Jan Beulich
2011-04-14 16:05 ` Keir Fraser
2011-04-14 16:28 ` Jan Beulich
2011-04-14 16:48 ` Keir Fraser
2011-04-14 18:33 ` Wang, Winston L
2011-04-14 21:06 ` Keir Fraser
2011-04-14 21:37 ` Wang, Winston L
2011-04-15 7:06 ` Jan Beulich
2011-04-15 7:08 ` Jan Beulich
2011-04-15 7:37 ` Keir Fraser
2011-04-15 14:49 ` Wang, Winston L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9CDA6D0.16614%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=dan.magenheimer@oracle.com \
--cc=winston.l.wang@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.