From: Keir Fraser <keir.xen@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var
Date: Mon, 18 Jul 2011 10:37:54 +0100 [thread overview]
Message-ID: <CA49BD82.1E170%keir.xen@gmail.com> (raw)
In-Reply-To: <20110718090416.GA23376@aepfle.de>
On 18/07/2011 10:04, "Olaf Hering" <olaf@aepfle.de> wrote:
> On Sat, Jul 16, Keir Fraser wrote:
>
>> It's not like we have dodgy third-party drivers to worry about. Just fix the
>> code -- *which is in the tree!* -- that is making the bad calls! It was
>> correct to make this an assert/bug_on in the first place.
>
> trace_irq_mask() was the only function I found with a too large buffer.
Yes, the fix was the very next email I looked at. I've applied it. Thanks!
-- Keir
> Olaf
next prev parent reply other threads:[~2011-07-18 9:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 15:38 [PATCH 0 of 4] xentrace fixes for xen-unstable Olaf Hering
2011-07-15 15:38 ` [PATCH 1 of 4] hvm: remove cast from trace_var call for HVMOP_xentrace Olaf Hering
2011-07-15 15:48 ` George Dunlap
2011-07-15 15:38 ` [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var Olaf Hering
2011-07-15 16:31 ` George Dunlap
2011-07-16 8:20 ` Keir Fraser
2011-07-18 9:04 ` Olaf Hering
2011-07-18 9:37 ` Keir Fraser [this message]
2011-07-18 10:41 ` George Dunlap
2011-07-18 11:12 ` Keir Fraser
2011-07-15 15:38 ` [PATCH 3 of 4] xentrace: reduce size of extradata in trace_irq_mask() Olaf Hering
2011-07-15 16:28 ` George Dunlap
2011-07-16 8:25 ` Keir Fraser
2011-07-15 15:38 ` [PATCH 4 of 4] Add a trace hypercall to allow tracing from dom0 or domU Olaf Hering
2011-07-15 16:49 ` George Dunlap
2011-07-15 20:45 ` Olaf Hering
2011-07-18 8:56 ` Tim Deegan
2011-07-18 11:17 ` George Dunlap
2011-07-18 12:22 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA49BD82.1E170%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.