From: George Dunlap <george.dunlap@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 4] hvm: remove cast from trace_var call for HVMOP_xentrace
Date: Fri, 15 Jul 2011 16:48:56 +0100 [thread overview]
Message-ID: <1310744936.448.51.camel@elijah> (raw)
In-Reply-To: <d0dcdddf5285eba0605a.1310744285@probook.site>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
On Fri, 2011-07-15 at 16:38 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1310741122 -7200
> # Node ID d0dcdddf5285eba0605a95dfda79b794803fa733
> # Parent fbb448cf5cba5f441ad94f7783a0a1394fd638f9
> hvm: remove cast from trace_var call for HVMOP_xentrace
>
> trace_var() takes a void pointer, casting is not needed.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> diff -r fbb448cf5cba -r d0dcdddf5285 xen/arch/x86/hvm/hvm.c
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3926,8 +3926,7 @@ long do_hvm_op(unsigned long op, XEN_GUE
>
> /* Cycles will be taken at the vmexit and vmenter */
> trace_var(tr.event | TRC_GUEST, 0 /*!cycles*/,
> - tr.extra_bytes,
> - (unsigned char *)tr.extra);
> + tr.extra_bytes, tr.extra);
> break;
> }
>
next prev parent reply other threads:[~2011-07-15 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 15:38 [PATCH 0 of 4] xentrace fixes for xen-unstable Olaf Hering
2011-07-15 15:38 ` [PATCH 1 of 4] hvm: remove cast from trace_var call for HVMOP_xentrace Olaf Hering
2011-07-15 15:48 ` George Dunlap [this message]
2011-07-15 15:38 ` [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var Olaf Hering
2011-07-15 16:31 ` George Dunlap
2011-07-16 8:20 ` Keir Fraser
2011-07-18 9:04 ` Olaf Hering
2011-07-18 9:37 ` Keir Fraser
2011-07-18 10:41 ` George Dunlap
2011-07-18 11:12 ` Keir Fraser
2011-07-15 15:38 ` [PATCH 3 of 4] xentrace: reduce size of extradata in trace_irq_mask() Olaf Hering
2011-07-15 16:28 ` George Dunlap
2011-07-16 8:25 ` Keir Fraser
2011-07-15 15:38 ` [PATCH 4 of 4] Add a trace hypercall to allow tracing from dom0 or domU Olaf Hering
2011-07-15 16:49 ` George Dunlap
2011-07-15 20:45 ` Olaf Hering
2011-07-18 8:56 ` Tim Deegan
2011-07-18 11:17 ` George Dunlap
2011-07-18 12:22 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310744936.448.51.camel@elijah \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.