From: Keir Fraser <keir.xen@gmail.com>
To: Bei Guan <gbtju85@gmail.com>, Keir Fraser <keir@xen.org>
Cc: edk2-devel@lists.sourceforge.net,
Xen Devel <xen-devel@lists.xensource.com>,
Jordan Justen <jljusten@gmail.com>,
Tim Deegan <Tim.Deegan@citrix.com>,
Andrei Warkentin <andreiw@motorola.com>
Subject: Re: [PATCH 1 of 3] Enable UEFI BIOS(OVMF) support in Xen-unstable HVM
Date: Sat, 23 Jul 2011 17:50:32 +0100 [thread overview]
Message-ID: <CA50BA68.1E732%keir.xen@gmail.com> (raw)
In-Reply-To: <CAEQjb-TUxF7BUJx-ProK83fciByoLrNfso3URjEnkT2LeVutWQ@mail.gmail.com>
On 23/07/2011 16:18, "Bei Guan" <gbtju85@gmail.com> wrote:
> Do you mean that put the bios_relocate hook in the "else" statement? Just like
> this:
>
> if (bios->load) {
> bios->load(bios);
> } else {
> printf("Loading %s ...\n", bios->name);
> memcpy((void *)bios->bios_address, bios->image,
> bios->image_size);
>
> if (bios->bios_relocate)
> bios->bios_relocate();
> }
No I mean remove the bios_relocate hook entirely, and modify the rombios
handler to use your new hook instead. It should be quite easy.
-- Keir
next prev parent reply other threads:[~2011-07-23 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 16:23 [PATCH 1 of 3] Enable UEFI BIOS(OVMF) support in Xen-unstable HVM Bei Guan
2011-07-22 16:38 ` Keir Fraser
2011-07-22 18:38 ` Andrei Warkentin
2011-07-23 6:53 ` Keir Fraser
2011-07-23 9:06 ` Keir Fraser
2011-07-23 15:18 ` Bei Guan
2011-07-23 16:50 ` Keir Fraser [this message]
2011-07-25 14:03 ` Konrad Rzeszutek Wilk
2011-07-25 14:17 ` Keir Fraser
2011-07-25 15:12 ` Bei Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA50BA68.1E732%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Tim.Deegan@citrix.com \
--cc=andreiw@motorola.com \
--cc=edk2-devel@lists.sourceforge.net \
--cc=gbtju85@gmail.com \
--cc=jljusten@gmail.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.