From: Keir Fraser <keir@xen.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jan Beulich <JBeulich@suse.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: <linux-pci@vger.kernel.org>, <xen-devel@lists.xensource.com>,
<linux-kernel@vger.kernel.org>, <jbarnes@virtuousgeek.org>
Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id.
Date: Fri, 06 Jan 2012 15:50:04 +0000 [thread overview]
Message-ID: <CB2CC8AC.36FD5%keir@xen.org> (raw)
In-Reply-To: <20120106150338.GB5855@phenom.dumpdata.com>
On 06/01/2012 15:03, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
>> As you're touching this anyway, how about fixing the other minor
>> issues with it too? E.g.
>>
>> dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
>> " Overwriting the ownership, but beware.\n",
>> xen_find_device_domain_owner(dev));
>>
>> (a native English speaker may want to comment the "but beware"
>> part - it reads odd for me).
>
> Hm, lets ask the English speakers. Ian?
The suggested reworking above is an improvement. The "but beware" bit is
fine.
-- keir
WARNING: multiple messages have this Message-ID (diff)
From: Keir Fraser <keir@xen.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jan Beulich <JBeulich@suse.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: linux-pci@vger.kernel.org, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id.
Date: Fri, 06 Jan 2012 15:50:04 +0000 [thread overview]
Message-ID: <CB2CC8AC.36FD5%keir@xen.org> (raw)
In-Reply-To: <20120106150338.GB5855@phenom.dumpdata.com>
On 06/01/2012 15:03, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
>> As you're touching this anyway, how about fixing the other minor
>> issues with it too? E.g.
>>
>> dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
>> " Overwriting the ownership, but beware.\n",
>> xen_find_device_domain_owner(dev));
>>
>> (a native English speaker may want to comment the "but beware"
>> part - it reads odd for me).
>
> Hm, lets ask the English speakers. Ian?
The suggested reworking above is an improvement. The "but beware" bit is
fine.
-- keir
next prev parent reply other threads:[~2012-01-06 15:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 0:46 [PATCH] Support Function Level Reset (FLR) in the xen-pciback module (v1) and some fixes Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 1/5] pci: Introduce __pci_reset_function_locked to be used when holding device_lock Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 2/5] xen/pciback: Support pci_reset_function, aka FLR or D3 support Konrad Rzeszutek Wilk
2012-01-05 10:24 ` [Xen-devel] " Ian Campbell
2012-01-05 18:58 ` Don Dutile
2012-01-05 21:34 ` Konrad Rzeszutek Wilk
2012-01-06 16:53 ` Don Dutile
2012-01-06 16:17 ` Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 3/5] xen/pciback: Move the PCI_DEV_FLAGS_ASSIGNED ops to the "[un|]bind" Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 4/5] xen/pciback: Expand the warning message to include domain id Konrad Rzeszutek Wilk
2012-01-06 8:38 ` [Xen-devel] " Jan Beulich
2012-01-06 8:38 ` Jan Beulich
2012-01-06 11:03 ` Andrew Cooper
2012-01-06 15:03 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-01-06 15:50 ` Keir Fraser [this message]
2012-01-06 15:50 ` Keir Fraser
2012-01-06 15:51 ` Ian Campbell
2012-01-06 16:00 ` Konrad Rzeszutek Wilk
2012-01-06 22:19 ` Konrad Rzeszutek Wilk
2012-01-09 9:29 ` Jan Beulich
2012-01-09 9:50 ` Ian Campbell
2012-01-09 15:11 ` Konrad Rzeszutek Wilk
2012-01-09 15:16 ` Ian Campbell
2012-01-09 15:22 ` Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 5/5] xen/pciback: Fix "device has been assigned to X domain!" warning Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB2CC8AC.36FD5%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=jbarnes@virtuousgeek.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.