* [PATCH] gadget init: don't dump info to info.txt on boot
@ 2012-03-07 9:11 Koen Kooi
2012-03-07 15:20 ` Jason Kridner
0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-03-07 9:11 UTC (permalink / raw)
To: meta-ti
This script adds ~10s to the boot time, doesn't have error checking and prevents loading the storage gadget 3 out of 10 times.
Remove it from ExecStartPre to get a fast, consistent boot. The functionality should be moved to bone101.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
recipes-ti/beagleboard/gadget-init.bb | 2 +-
.../gadget-init/storage-gadget-init.service | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/recipes-ti/beagleboard/gadget-init.bb b/recipes-ti/beagleboard/gadget-init.bb
index 016877d..1a6a336 100644
--- a/recipes-ti/beagleboard/gadget-init.bb
+++ b/recipes-ti/beagleboard/gadget-init.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Units to initialize usb gadgets"
-PR = "r18"
+PR = "r19"
LICENSE = "MIT"
LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
diff --git a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
index 601e0d7..9a8513e 100644
--- a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
+++ b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
@@ -4,7 +4,6 @@ After=dev-mmcblk0p1.device
[Service]
RemainAfterExit=yes
-ExecStartPre=/usr/bin/update-image-info-on-mmcblk0p1.sh
ExecStart=/sbin/modprobe g_mass_storage file=/dev/mmcblk0p1 cdrom=0 stall=0 removable=1 nofua=1
ExecStop=/sbin/rmmod g_mass_storage
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] gadget init: don't dump info to info.txt on boot
2012-03-07 9:11 [PATCH] gadget init: don't dump info to info.txt on boot Koen Kooi
@ 2012-03-07 15:20 ` Jason Kridner
2012-03-07 15:22 ` Koen Kooi
0 siblings, 1 reply; 5+ messages in thread
From: Jason Kridner @ 2012-03-07 15:20 UTC (permalink / raw)
To: Koen Kooi; +Cc: meta-ti@lists.yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
On Wednesday, March 7, 2012, Koen Kooi wrote:
> This script adds ~10s to the boot time, doesn't have error checking and
> prevents loading the storage gadget 3 out of 10 times.
>
What is the root cause? Would it be better to add error checking?
>
> Remove it from ExecStartPre to get a fast, consistent boot. The
> functionality should be moved to bone101.
>
If the drive is already mounted, is it valid to edit this file? (I would
think not.)
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net <javascript:;>>
> ---
> recipes-ti/beagleboard/gadget-init.bb | 2 +-
> .../gadget-init/storage-gadget-init.service | 1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-ti/beagleboard/gadget-init.bbb/recipes-ti/beagleboard/
> gadget-init.bb
> index 016877d..1a6a336 100644
> --- a/recipes-ti/beagleboard/gadget-init.bb
> +++ b/recipes-ti/beagleboard/gadget-init.bb
> @@ -1,6 +1,6 @@
> DESCRIPTION = "Units to initialize usb gadgets"
>
> -PR = "r18"
> +PR = "r19"
>
> LICENSE = "MIT"
> LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
> diff --git
> a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> index 601e0d7..9a8513e 100644
> --- a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> +++ b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> @@ -4,7 +4,6 @@ After=dev-mmcblk0p1.device
>
> [Service]
> RemainAfterExit=yes
> -ExecStartPre=/usr/bin/update-image-info-on-mmcblk0p1.sh
> ExecStart=/sbin/modprobe g_mass_storage file=/dev/mmcblk0p1 cdrom=0
> stall=0 removable=1 nofua=1
> ExecStop=/sbin/rmmod g_mass_storage
>
> --
> 1.7.2.5
>
>
[-- Attachment #2: Type: text/html, Size: 2693 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gadget init: don't dump info to info.txt on boot
2012-03-07 15:20 ` Jason Kridner
@ 2012-03-07 15:22 ` Koen Kooi
2012-03-07 15:25 ` Kridner, Jason
0 siblings, 1 reply; 5+ messages in thread
From: Koen Kooi @ 2012-03-07 15:22 UTC (permalink / raw)
To: Jason Kridner; +Cc: meta-ti@lists.yoctoproject.org
Op 7 mrt. 2012, om 16:20 heeft Jason Kridner het volgende geschreven:
> On Wednesday, March 7, 2012, Koen Kooi wrote:
> This script adds ~10s to the boot time, doesn't have error checking and prevents loading the storage gadget 3 out of 10 times.
>
> What is the root cause? Would it be better to add error checking?
I'm not going to add error checking, so chances are slim it will get fixed in time for the release.
> Remove it from ExecStartPre to get a fast, consistent boot. The functionality should be moved to bone101.
>
> If the drive is already mounted, is it valid to edit this file? (I would think not.)
It wouldn't touch the drive, it would show the info on the webpage.
regards,
Koen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gadget init: don't dump info to info.txt on boot
2012-03-07 15:22 ` Koen Kooi
@ 2012-03-07 15:25 ` Kridner, Jason
2012-03-07 15:28 ` Koen Kooi
0 siblings, 1 reply; 5+ messages in thread
From: Kridner, Jason @ 2012-03-07 15:25 UTC (permalink / raw)
To: Koen Kooi, Jason Kridner; +Cc: meta-ti@lists.yoctoproject.org
On 3/7/12 10:22 AM, "Koen Kooi" <koen@dominion.thruhere.net> wrote:
>
>Op 7 mrt. 2012, om 16:20 heeft Jason Kridner het volgende geschreven:
>
>> On Wednesday, March 7, 2012, Koen Kooi wrote:
>> This script adds ~10s to the boot time, doesn't have error checking and
>>prevents loading the storage gadget 3 out of 10 times.
>>
>> What is the root cause? Would it be better to add error checking?
>
>I'm not going to add error checking, so chances are slim it will get
>fixed in time for the release.
>
>> Remove it from ExecStartPre to get a fast, consistent boot. The
>>functionality should be moved to bone101.
>>
>> If the drive is already mounted, is it valid to edit this file? (I
>>would think not.)
>
>It wouldn't touch the drive, it would show the info on the webpage.
That makes some sense, but the need to "eject the drive" before this info
shows up makes me think some people might miss it. Removing the info.txt
functionality needs an update to README.htm to stop pointing to it and I
think it makes sense to switch to the composite MSC+RNDIS+serial gadget
driver to avoid the need to eject to be able to see this information.
>
>regards,
>
>Koen
>_______________________________________________
>meta-ti mailing list
>meta-ti@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gadget init: don't dump info to info.txt on boot
2012-03-07 15:25 ` Kridner, Jason
@ 2012-03-07 15:28 ` Koen Kooi
0 siblings, 0 replies; 5+ messages in thread
From: Koen Kooi @ 2012-03-07 15:28 UTC (permalink / raw)
To: Jason Kridner; +Cc: meta-ti@lists.yoctoproject.org
Op 7 mrt. 2012, om 16:25 heeft Kridner, Jason het volgende geschreven:
>
>
> On 3/7/12 10:22 AM, "Koen Kooi" <koen@dominion.thruhere.net> wrote:
>
>>
>> Op 7 mrt. 2012, om 16:20 heeft Jason Kridner het volgende geschreven:
>>
>>> On Wednesday, March 7, 2012, Koen Kooi wrote:
>>> This script adds ~10s to the boot time, doesn't have error checking and
>>> prevents loading the storage gadget 3 out of 10 times.
>>>
>>> What is the root cause? Would it be better to add error checking?
>>
>> I'm not going to add error checking, so chances are slim it will get
>> fixed in time for the release.
>>
>>> Remove it from ExecStartPre to get a fast, consistent boot. The
>>> functionality should be moved to bone101.
>>>
>>> If the drive is already mounted, is it valid to edit this file? (I
>>> would think not.)
>>
>> It wouldn't touch the drive, it would show the info on the webpage.
>
> That makes some sense, but the need to "eject the drive" before this info
> shows up makes me think some people might miss it. Removing the info.txt
> functionality needs an update to README.htm to stop pointing to it and I
> think it makes sense to switch to the composite MSC+RNDIS+serial gadget
> driver to avoid the need to eject to be able to see this information.
Exactly, the current 3.2.9 kernel should be safe enough to use g_multi on.
regards,
Koen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-07 15:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 9:11 [PATCH] gadget init: don't dump info to info.txt on boot Koen Kooi
2012-03-07 15:20 ` Jason Kridner
2012-03-07 15:22 ` Koen Kooi
2012-03-07 15:25 ` Kridner, Jason
2012-03-07 15:28 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.