* [PATCH] x86/cpuidle: improve data arrangement
@ 2012-03-08 12:46 Jan Beulich
2012-03-08 14:05 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2012-03-08 12:46 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
.. to reduce the amount of holes (wasted space).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/xen/cpuidle.h
+++ b/xen/include/xen/cpuidle.h
@@ -40,9 +40,9 @@
struct acpi_processor_cx
{
u8 idx;
- u8 type;
- u32 address;
+ u8 type; /* ACPI_STATE_Cn */
u8 entry_method; /* ACPI_CSTATE_EM_xxx */
+ u32 address;
u32 latency;
u32 latency_ticks;
u32 power;
@@ -66,8 +66,8 @@ struct acpi_processor_power
struct acpi_processor_flags flags;
struct acpi_processor_cx *last_state;
struct acpi_processor_cx *safe_state;
- u32 last_residency;
void *gdata; /* governor specific data */
+ u32 last_residency;
u32 count;
struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER];
};
[-- Attachment #2: x86-cpuidle-data-arrange.patch --]
[-- Type: text/plain, Size: 841 bytes --]
x86/cpuidle: improve data arrangement
.. to reduce the amount of holes (wasted space).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/xen/cpuidle.h
+++ b/xen/include/xen/cpuidle.h
@@ -40,9 +40,9 @@
struct acpi_processor_cx
{
u8 idx;
- u8 type;
- u32 address;
+ u8 type; /* ACPI_STATE_Cn */
u8 entry_method; /* ACPI_CSTATE_EM_xxx */
+ u32 address;
u32 latency;
u32 latency_ticks;
u32 power;
@@ -66,8 +66,8 @@ struct acpi_processor_power
struct acpi_processor_flags flags;
struct acpi_processor_cx *last_state;
struct acpi_processor_cx *safe_state;
- u32 last_residency;
void *gdata; /* governor specific data */
+ u32 last_residency;
u32 count;
struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER];
};
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/cpuidle: improve data arrangement
2012-03-08 12:46 [PATCH] x86/cpuidle: improve data arrangement Jan Beulich
@ 2012-03-08 14:05 ` Keir Fraser
2012-03-08 14:44 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Keir Fraser @ 2012-03-08 14:05 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 08/03/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
> .. to reduce the amount of holes (wasted space).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/include/xen/cpuidle.h
> +++ b/xen/include/xen/cpuidle.h
> @@ -40,9 +40,9 @@
> struct acpi_processor_cx
> {
> u8 idx;
> - u8 type;
> - u32 address;
> + u8 type; /* ACPI_STATE_Cn */
> u8 entry_method; /* ACPI_CSTATE_EM_xxx */
> + u32 address;
> u32 latency;
> u32 latency_ticks;
> u32 power;
> @@ -66,8 +66,8 @@ struct acpi_processor_power
> struct acpi_processor_flags flags;
> struct acpi_processor_cx *last_state;
> struct acpi_processor_cx *safe_state;
> - u32 last_residency;
> void *gdata; /* governor specific data */
> + u32 last_residency;
> u32 count;
> struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER];
> };
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/cpuidle: improve data arrangement
2012-03-08 14:05 ` Keir Fraser
@ 2012-03-08 14:44 ` Jan Beulich
2012-03-08 15:25 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2012-03-08 14:44 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel
>>> On 08.03.12 at 15:05, Keir Fraser <keir.xen@gmail.com> wrote:
> On 08/03/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
>
>> .. to reduce the amount of holes (wasted space).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Keir Fraser <keir@xen.org>
This won't apply without http://lists.xen.org/archives/html/xen-devel/2012-03/msg00586.html;
do you have an opinion on that one?
Also, knowing that you're usually pretty quick in responding - did you
possibly overlook http://lists.xen.org/archives/html/xen-devel/2012-03/msg00440.html?
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/cpuidle: improve data arrangement
2012-03-08 14:44 ` Jan Beulich
@ 2012-03-08 15:25 ` Keir Fraser
0 siblings, 0 replies; 4+ messages in thread
From: Keir Fraser @ 2012-03-08 15:25 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On 08/03/2012 14:44, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 08.03.12 at 15:05, Keir Fraser <keir.xen@gmail.com> wrote:
>> On 08/03/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
>>
>>> .. to reduce the amount of holes (wasted space).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Acked-by: Keir Fraser <keir@xen.org>
>
> This won't apply without
> http://lists.xen.org/archives/html/xen-devel/2012-03/msg00586.html;
> do you have an opinion on that one?
No strong opinion on this one.
Acked-by: Keir Fraser <keir@xen.org>
> Also, knowing that you're usually pretty quick in responding - did you
> possibly overlook
> http://lists.xen.org/archives/html/xen-devel/2012-03/msg00440.html>
Must have missed it somehow. Looks fine.
Acked-by: Keir Fraser <keir@xen.org>
> Jan
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-08 15:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 12:46 [PATCH] x86/cpuidle: improve data arrangement Jan Beulich
2012-03-08 14:05 ` Keir Fraser
2012-03-08 14:44 ` Jan Beulich
2012-03-08 15:25 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.