From: Keir Fraser <keir.xen@gmail.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Qiu, Shuang" <shuang.qiu@intel.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: use tasklet to handle init/sipi?
Date: Tue, 26 Mar 2013 07:00:47 +0000 [thread overview]
Message-ID: <CD76F81F.1BBC7%keir.xen@gmail.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E099F208C@SHSMSX101.ccr.corp.intel.com>
On 26/03/2013 06:14, "Zhang, Yang Z" <yang.z.zhang@intel.com> wrote:
>> You'll have t elaborate on the problem *you* are trying to solve, and why
>> such a change would do the trick. If there's good reason, I'm not against a
>> change such as this. But the code is subtle and I don't want to mess with it
>> if there are simpler solutions.
> The problem is:
> With apicv support, the apic write is trap like vmexit. We cannot fallback to
> guest to retry the instruction. So it will break current logic.
Oh, I see. Well I think it is fine to have
vlapic_schedule_init_sipi_tasklet() return X86EMUL_OKAY rather than
X86EMUL_RETRY. We used to need to return RETRY, but the code got simplified
and now it is actually unnecessary.
That should make your patch a lot simpler eh? ;)
-- Keir
next prev parent reply other threads:[~2013-03-26 7:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 5:31 use tasklet to handle init/sipi? Zhang, Yang Z
2013-03-25 6:29 ` Keir Fraser
2013-03-25 6:55 ` Zhang, Yang Z
2013-03-25 8:05 ` Keir Fraser
2013-03-25 12:16 ` Zhang, Yang Z
2013-03-25 12:38 ` Jan Beulich
2013-03-25 12:39 ` Keir Fraser
2013-03-26 3:15 ` Zhang, Yang Z
2013-03-26 6:07 ` Keir Fraser
2013-03-26 6:14 ` Zhang, Yang Z
2013-03-26 7:00 ` Keir Fraser [this message]
2013-03-26 7:11 ` Keir Fraser
2013-03-26 7:17 ` Zhang, Yang Z
2013-03-26 7:38 ` Keir Fraser
2013-03-26 7:41 ` Zhang, Yang Z
2013-03-26 7:55 ` Keir Fraser
2013-03-26 8:02 ` Keir Fraser
2013-03-28 1:18 ` Zhang, Yang Z
2013-03-28 6:39 ` Qiu, Shuang
2013-03-28 11:48 ` Keir Fraser
2013-03-28 15:29 ` Jan Beulich
2013-03-28 20:02 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD76F81F.1BBC7%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=jbeulich@suse.com \
--cc=shuang.qiu@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.