All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Johan Hovold" <johan@kernel.org>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Vinod Koul" <vkoul@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<~postmarketos/upstreaming@lists.sr.ht>,
	<phone-devel@vger.kernel.org>, "Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] phy: qcom-qmp-combo: Add config for SM6350
Date: Mon, 23 Jan 2023 14:31:11 +0100	[thread overview]
Message-ID: <CPZLUWRUS9F0.1JP84TJFB2SPQ@otso> (raw)
In-Reply-To: <Y853iEBf1e7uh/wX@hovoldconsulting.com>

On Mon Jan 23, 2023 at 1:03 PM CET, Johan Hovold wrote:
> On Mon, Jan 23, 2023 at 12:22:32PM +0100, Luca Weiss wrote:
> > On Mon Jan 23, 2023 at 12:15 PM CET, Dmitry Baryshkov wrote:
>
> > > There are two SERDES regions. One used by USB part of the PHY (at 
> > > 0x1000) and another SERDES region used for DP (at 0x2000). As Johan 
> > > described below, vendor kernel handles the DP regions in the DP driver. 
> > > Possibly this caused a confusion on your side.
> > 
> > Ack, I think I got it now. I also see the registers used downstream
> > now, e.g.:
> > 
> > techpack/display/pll/dp_pll_10nm_util.c:#define QSERDES_COM_LOCK_CMP2_MODE0             0x009C
> > 
> > So now .dp_serdes should be 0x2000. Do I need to change anything else
> > also? I think not?
>
> You also need to add new dp_tx/rx pointers to the offset struct and use
> those in favour of the current ones if set. I think we hashed that bit
> out in one of the previous versions of this patch.

Thanks for the persistent help, I've sent out v4 now, I hope that's good
now and we can get this into v6.3 :)

>
> Johan


WARNING: multiple messages have this Message-ID (diff)
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Johan Hovold" <johan@kernel.org>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Vinod Koul" <vkoul@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<~postmarketos/upstreaming@lists.sr.ht>,
	<phone-devel@vger.kernel.org>, "Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] phy: qcom-qmp-combo: Add config for SM6350
Date: Mon, 23 Jan 2023 14:31:11 +0100	[thread overview]
Message-ID: <CPZLUWRUS9F0.1JP84TJFB2SPQ@otso> (raw)
In-Reply-To: <Y853iEBf1e7uh/wX@hovoldconsulting.com>

On Mon Jan 23, 2023 at 1:03 PM CET, Johan Hovold wrote:
> On Mon, Jan 23, 2023 at 12:22:32PM +0100, Luca Weiss wrote:
> > On Mon Jan 23, 2023 at 12:15 PM CET, Dmitry Baryshkov wrote:
>
> > > There are two SERDES regions. One used by USB part of the PHY (at 
> > > 0x1000) and another SERDES region used for DP (at 0x2000). As Johan 
> > > described below, vendor kernel handles the DP regions in the DP driver. 
> > > Possibly this caused a confusion on your side.
> > 
> > Ack, I think I got it now. I also see the registers used downstream
> > now, e.g.:
> > 
> > techpack/display/pll/dp_pll_10nm_util.c:#define QSERDES_COM_LOCK_CMP2_MODE0             0x009C
> > 
> > So now .dp_serdes should be 0x2000. Do I need to change anything else
> > also? I think not?
>
> You also need to add new dp_tx/rx pointers to the offset struct and use
> those in favour of the current ones if set. I think we hashed that bit
> out in one of the previous versions of this patch.

Thanks for the persistent help, I've sent out v4 now, I hope that's good
now and we can get this into v6.3 :)

>
> Johan


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2023-01-23 13:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  8:14 [PATCH v3 1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible Luca Weiss
2022-11-30  8:14 ` Luca Weiss
2022-11-30  8:14 ` [PATCH v3 2/3] phy: qcom-qmp-combo: Add config for SM6350 Luca Weiss
2022-11-30  8:14   ` Luca Weiss
2022-12-28 14:17   ` Johan Hovold
2022-12-28 14:17     ` Johan Hovold
2022-12-28 14:36     ` Luca Weiss
2022-12-28 14:36       ` Luca Weiss
2023-01-12 17:50     ` Vinod Koul
2023-01-12 17:50       ` Vinod Koul
2023-01-12 19:33       ` Dmitry Baryshkov
2023-01-12 19:33         ` Dmitry Baryshkov
2023-01-13 12:44         ` Luca Weiss
2023-01-13 12:44           ` Luca Weiss
2023-01-13 13:01           ` Dmitry Baryshkov
2023-01-13 13:01             ` Dmitry Baryshkov
2023-01-20 14:13             ` Luca Weiss
2023-01-20 14:13               ` Luca Weiss
2023-01-23  9:43               ` Johan Hovold
2023-01-23  9:43                 ` Johan Hovold
2023-01-23 11:15                 ` Dmitry Baryshkov
2023-01-23 11:15                   ` Dmitry Baryshkov
2023-01-23 11:22                   ` Luca Weiss
2023-01-23 11:22                     ` Luca Weiss
2023-01-23 12:03                     ` Johan Hovold
2023-01-23 12:03                       ` Johan Hovold
2023-01-23 13:31                       ` Luca Weiss [this message]
2023-01-23 13:31                         ` Luca Weiss
2023-01-23 12:05                   ` Johan Hovold
2023-01-23 12:05                     ` Johan Hovold
2023-01-23 12:09                     ` Dmitry Baryshkov
2023-01-23 12:09                       ` Dmitry Baryshkov
2022-11-30  8:14 ` [PATCH v3 3/3] arm64: dts: qcom: sm6350: Use specific qmpphy compatible Luca Weiss
2022-12-28 14:23   ` Johan Hovold
2022-12-01 16:27 ` [PATCH v3 1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible Krzysztof Kozlowski
2022-12-01 16:27   ` Krzysztof Kozlowski
2022-12-28 14:11 ` Johan Hovold
2022-12-28 14:11   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CPZLUWRUS9F0.1JP84TJFB2SPQ@otso \
    --to=luca.weiss@fairphone.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan@kernel.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.