All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robin Jarry" <robin@jarry.cc>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: <phillip.wood@dunelm.org.uk>, <git@vger.kernel.org>,
	"Tim Culverhouse" <tim@timculverhouse.com>,
	"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH RESEND] hooks: add sendemail-validate-series
Date: Wed, 05 Apr 2023 10:31:28 +0200	[thread overview]
Message-ID: <CROOKNR29PDV.1WIGA6219L1C6@ringo> (raw)
In-Reply-To: <xmqqbkk3z9p9.fsf@gitster.g>

Junio C Hamano, Apr 04, 2023 at 22:14:
> Feeding the filenames as the command line arguments would have been
> much simpler X-<,

Just a thought. Instead of adding another hook, wouldn't it be better to
add an option --validate-series (git config sendemail.validateSeries)
that would change the behaviour of the sendemail-validate hook? Calling
it with all patch files as command line arguments only once instead of
once per file.

I know I was concerned with the max size of the command line args but is
there really a chance that we hit that maximum? On my system, it is
2097152 bytes. Even with a 1000 patches series with 1000 bytes
filenames, we wouldn't hit the limit.

This way, we support any crap filename that the user may send and we
don't add a new hook which basically does the same thing than the
existing one.

Thoughts?

  reply	other threads:[~2023-04-05  8:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 18:56 [PATCH RESEND] hooks: add sendemail-validate-series Robin Jarry
2023-04-03  0:17 ` Eric Sunshine
2023-04-03 14:09 ` Phillip Wood
2023-04-03 14:32   ` Robin Jarry
2023-04-03 15:20     ` Phillip Wood
2023-04-03 15:42   ` Junio C Hamano
2023-04-03 17:25     ` Robin Jarry
2023-04-03 22:29   ` Robin Jarry
2023-04-03 22:52     ` Junio C Hamano
2023-04-03 22:59       ` Robin Jarry
2023-04-04 20:14         ` Junio C Hamano
2023-04-05  8:31           ` Robin Jarry [this message]
2023-04-05 21:49             ` Junio C Hamano
2023-04-05 23:13 ` [PATCH v2] " Robin Jarry
2023-04-06  8:56   ` Ævar Arnfjörð Bjarmason
2023-04-11  9:58     ` Phillip Wood
2023-04-11 10:39       ` Robin Jarry
2023-04-11 15:58       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CROOKNR29PDV.1WIGA6219L1C6@ringo \
    --to=robin@jarry.cc \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sunshine@sunshineco.com \
    --cc=tim@timculverhouse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.