All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Clay Chang" <clayc@hpe.com>, <keyrings@vger.kernel.org>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <dhowells@redhat.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>
Subject: Re: [PATCH] KEYS: include header for EINVAL definition
Date: Sat, 13 Jan 2024 22:46:57 +0200	[thread overview]
Message-ID: <CYDVFYGDLJFC.1IAQAPLY6VRWX@kernel.org> (raw)
In-Reply-To: <a8ad036a-7d65-4dbe-8c87-f569e54d7a57@hpe.com>

On Fri Jan 12, 2024 at 7:59 AM EET, Clay Chang wrote:
> Hi Jarkko,
>
> Yes, I have. I am working on an OpenBMC project and the kernel .config was generated by merging several config fragments. In one experiment where the CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL undeclared compilation error.
>
> Do you want me to show the full .config here?

Well the problem with the patch is that it does not *prove*
that there is issue.

So you evidence in the commit message that there is bug in
the first place and which config options cause it. And it
it must be testable with latest mainline (not by downstream
project).

BR, Jarkko

  reply	other threads:[~2024-01-13 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07 13:28 [PATCH] KEYS: include header for EINVAL definition clayc
2024-01-08 14:24 ` Jarkko Sakkinen
2024-01-09  2:10   ` Clay Chang
2024-01-10 19:54     ` Jarkko Sakkinen
2024-01-12  5:59       ` Clay Chang
2024-01-13 20:46         ` Jarkko Sakkinen [this message]
2024-01-26  8:59 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CYDVFYGDLJFC.1IAQAPLY6VRWX@kernel.org \
    --to=jarkko@kernel.org \
    --cc=clayc@hpe.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.