From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Thomas Richard" <thomas.richard@bootlin.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
thomas.petazzoni@bootlin.com, u-kumar1@ti.com
Subject: Re: [PATCH v3 18/18] PCI: j721e: add suspend and resume support
Date: Fri, 16 Feb 2024 12:09:17 +0100 [thread overview]
Message-ID: <CZ6GG6OQUJTX.2OM5TC9YLOAXV@bootlin.com> (raw)
In-Reply-To: <aa791703-81d8-420c-ba35-c8fd08bc3f07@ti.com>
Hello,
On Fri Feb 16, 2024 at 11:48 AM CET, Siddharth Vadapalli wrote:
> On 24/02/15 04:18PM, Thomas Richard wrote:
> > From: Théo Lebrun <theo.lebrun@bootlin.com>
> >
> > Add suspend and resume support. Only the rc mode is supported.
> >
> > During the suspend stage PERST# is asserted, then deasserted during the
> > resume stage.
>
> Wouldn't this imply that the Endpoint device will be reset and therefore
> lose context? Or is it expected that the driver corresponding to the
> Endpoint Function in Linux will restore the state on resume, post reset?
This does imply exactly that. Endpoint driver must be able to restore
context anyway, as system-wide suspend could mean lost power to PCI RC
controller (eg suspend-to-RAM) or PCI rails (dependent on hardware).
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Thomas Richard" <thomas.richard@bootlin.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
thomas.petazzoni@bootlin.com, u-kumar1@ti.com
Subject: Re: [PATCH v3 18/18] PCI: j721e: add suspend and resume support
Date: Fri, 16 Feb 2024 12:09:17 +0100 [thread overview]
Message-ID: <CZ6GG6OQUJTX.2OM5TC9YLOAXV@bootlin.com> (raw)
In-Reply-To: <aa791703-81d8-420c-ba35-c8fd08bc3f07@ti.com>
Hello,
On Fri Feb 16, 2024 at 11:48 AM CET, Siddharth Vadapalli wrote:
> On 24/02/15 04:18PM, Thomas Richard wrote:
> > From: Théo Lebrun <theo.lebrun@bootlin.com>
> >
> > Add suspend and resume support. Only the rc mode is supported.
> >
> > During the suspend stage PERST# is asserted, then deasserted during the
> > resume stage.
>
> Wouldn't this imply that the Endpoint device will be reset and therefore
> lose context? Or is it expected that the driver corresponding to the
> Endpoint Function in Linux will restore the state on resume, post reset?
This does imply exactly that. Endpoint driver must be able to restore
context anyway, as system-wide suspend could mean lost power to PCI RC
controller (eg suspend-to-RAM) or PCI rails (dependent on hardware).
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Thomas Richard" <thomas.richard@bootlin.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
thomas.petazzoni@bootlin.com, u-kumar1@ti.com
Subject: Re: [PATCH v3 18/18] PCI: j721e: add suspend and resume support
Date: Fri, 16 Feb 2024 12:09:17 +0100 [thread overview]
Message-ID: <CZ6GG6OQUJTX.2OM5TC9YLOAXV@bootlin.com> (raw)
In-Reply-To: <aa791703-81d8-420c-ba35-c8fd08bc3f07@ti.com>
Hello,
On Fri Feb 16, 2024 at 11:48 AM CET, Siddharth Vadapalli wrote:
> On 24/02/15 04:18PM, Thomas Richard wrote:
> > From: Théo Lebrun <theo.lebrun@bootlin.com>
> >
> > Add suspend and resume support. Only the rc mode is supported.
> >
> > During the suspend stage PERST# is asserted, then deasserted during the
> > resume stage.
>
> Wouldn't this imply that the Endpoint device will be reset and therefore
> lose context? Or is it expected that the driver corresponding to the
> Endpoint Function in Linux will restore the state on resume, post reset?
This does imply exactly that. Endpoint driver must be able to restore
context anyway, as system-wide suspend could mean lost power to PCI RC
controller (eg suspend-to-RAM) or PCI rails (dependent on hardware).
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-16 11:09 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 15:17 [PATCH v3 00/18] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 01/18] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-21 21:54 ` Linus Walleij
2024-02-21 21:54 ` Linus Walleij
2024-02-21 21:54 ` Linus Walleij
2024-02-15 15:17 ` [PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:27 ` Andy Shevchenko
2024-02-15 15:27 ` Andy Shevchenko
2024-02-15 15:27 ` Andy Shevchenko
2024-02-16 7:59 ` Thomas Richard
2024-02-16 7:59 ` Thomas Richard
2024-02-16 7:59 ` Thomas Richard
2024-02-16 15:08 ` Andy Shevchenko
2024-02-16 15:08 ` Andy Shevchenko
2024-02-16 15:08 ` Andy Shevchenko
2024-02-21 11:01 ` Thomas Richard
2024-02-21 11:01 ` Thomas Richard
2024-02-21 11:01 ` Thomas Richard
2024-02-21 13:13 ` Andy Shevchenko
2024-02-21 13:13 ` Andy Shevchenko
2024-02-21 13:13 ` Andy Shevchenko
2024-02-21 14:19 ` Thomas Richard
2024-02-21 14:19 ` Thomas Richard
2024-02-21 14:19 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 03/18] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 04/18] i2c: omap: wakeup the controller during suspend() callback Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:30 ` Andy Shevchenko
2024-02-15 15:30 ` Andy Shevchenko
2024-02-15 15:30 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 05/18] mux: add mux_chip_resume() function Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:29 ` Andy Shevchenko
2024-02-15 15:29 ` Andy Shevchenko
2024-02-15 15:29 ` Andy Shevchenko
2024-02-16 7:52 ` Thomas Richard
2024-02-16 7:52 ` Thomas Richard
2024-02-16 7:52 ` Thomas Richard
2024-02-16 15:07 ` Andy Shevchenko
2024-02-16 15:07 ` Andy Shevchenko
2024-02-16 15:07 ` Andy Shevchenko
2024-02-21 10:59 ` Thomas Richard
2024-02-21 10:59 ` Thomas Richard
2024-02-21 10:59 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 06/18] mux: mmio: add resume support Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 07/18] phy: ti: phy-j721e-wiz: use dev_err_probe() instead of dev_err() Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:33 ` Andy Shevchenko
2024-02-15 15:33 ` Andy Shevchenko
2024-02-15 15:33 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 08/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:43 ` Andy Shevchenko
2024-02-15 15:43 ` Andy Shevchenko
2024-02-15 15:43 ` Andy Shevchenko
2024-02-16 6:02 ` Vinod Koul
2024-02-16 6:02 ` Vinod Koul
2024-02-16 6:02 ` Vinod Koul
2024-02-16 9:04 ` Siddharth Vadapalli
2024-02-16 9:04 ` Siddharth Vadapalli
2024-02-16 9:04 ` Siddharth Vadapalli
2024-02-16 15:03 ` Andy Shevchenko
2024-02-16 15:03 ` Andy Shevchenko
2024-02-16 15:03 ` Andy Shevchenko
2024-02-16 14:56 ` Andy Shevchenko
2024-02-16 14:56 ` Andy Shevchenko
2024-02-16 14:56 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 09/18] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 10/18] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 11/18] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 12/18] phy: cadence-torrent: add already_configured to struct cdns_torrent_phy Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:45 ` Andy Shevchenko
2024-02-15 15:45 ` Andy Shevchenko
2024-02-15 15:45 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 14/18] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:17 ` Thomas Richard
2024-02-15 15:46 ` Andy Shevchenko
2024-02-15 15:46 ` Andy Shevchenko
2024-02-15 15:46 ` Andy Shevchenko
2024-02-16 7:36 ` Thomas Richard
2024-02-16 7:36 ` Thomas Richard
2024-02-16 7:36 ` Thomas Richard
2024-02-21 13:09 ` Philipp Zabel
2024-02-21 13:09 ` Philipp Zabel
2024-02-21 13:09 ` Philipp Zabel
2024-02-21 13:41 ` Thomas Richard
2024-02-21 13:41 ` Thomas Richard
2024-02-21 13:41 ` Thomas Richard
2024-02-21 13:58 ` Philipp Zabel
2024-02-21 13:58 ` Philipp Zabel
2024-02-21 13:58 ` Philipp Zabel
2024-02-15 15:18 ` [PATCH v3 15/18] PCI: cadence: extract link setup sequence from cdns_pcie_host_setup() Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-16 9:34 ` Siddharth Vadapalli
2024-02-16 9:34 ` Siddharth Vadapalli
2024-02-16 9:34 ` Siddharth Vadapalli
2024-02-15 15:18 ` [PATCH v3 16/18] PCI: cadence: set cdns_pcie_host_init() global Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-16 9:38 ` Siddharth Vadapalli
2024-02-16 9:38 ` Siddharth Vadapalli
2024-02-16 9:38 ` Siddharth Vadapalli
2024-02-15 15:18 ` [PATCH v3 17/18] PCI: j721e: add reset GPIO to struct j721e_pcie Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 16:04 ` Andy Shevchenko
2024-02-15 16:04 ` Andy Shevchenko
2024-02-15 16:04 ` Andy Shevchenko
2024-02-26 17:05 ` Thomas Richard
2024-02-26 17:05 ` Thomas Richard
2024-02-26 17:05 ` Thomas Richard
2024-02-26 17:54 ` Andy Shevchenko
2024-02-26 17:54 ` Andy Shevchenko
2024-02-26 17:54 ` Andy Shevchenko
2024-02-15 15:18 ` [PATCH v3 18/18] PCI: j721e: add suspend and resume support Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 15:18 ` Thomas Richard
2024-02-15 15:51 ` Andy Shevchenko
2024-02-15 15:51 ` Andy Shevchenko
2024-02-15 15:51 ` Andy Shevchenko
2024-02-16 10:48 ` Siddharth Vadapalli
2024-02-16 10:48 ` Siddharth Vadapalli
2024-02-16 10:48 ` Siddharth Vadapalli
2024-02-16 11:09 ` Théo Lebrun [this message]
2024-02-16 11:09 ` Théo Lebrun
2024-02-16 11:09 ` Théo Lebrun
2024-02-16 11:16 ` Siddharth Vadapalli
2024-02-16 11:16 ` Siddharth Vadapalli
2024-02-16 11:16 ` Siddharth Vadapalli
2024-02-15 15:40 ` [PATCH v3 00/18] Add suspend to ram support for PCIe on J7200 Philipp Stanner
2024-02-15 15:40 ` Philipp Stanner
2024-02-15 15:40 ` Philipp Stanner
2024-02-15 17:06 ` Bjorn Helgaas
2024-02-15 17:06 ` Bjorn Helgaas
2024-02-15 17:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZ6GG6OQUJTX.2OM5TC9YLOAXV@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.