From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Andi Shyti" <andi.shyti@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller
Date: Mon, 11 Mar 2024 09:59:36 +0100 [thread overview]
Message-ID: <CZQSPYZUWFGD.1ZLSA295LSM77@bootlin.com> (raw)
In-Reply-To: <yyyhx62wcvro2zrkxmj6g3esg32zh62f4spox7txv4ghc74ewo@lzduga5d4wzi>
Hello,
On Fri Mar 8, 2024 at 11:54 PM CET, Andi Shyti wrote:
> Hi Theo,
>
> > +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> > + unsigned long reg)
>
> If you don't mind, I fixed this checkpatch warning while
> applying:
>
> CHECK: Alignment should match open parenthesis
> #103: FILE: drivers/i2c/busses/i2c-nomadik.c:247:
> +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> + unsigned long reg)
Indeed I do not mind. Thanks for the work!
Do ping me if any follow-up is required.
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Andi Shyti" <andi.shyti@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller
Date: Mon, 11 Mar 2024 09:59:36 +0100 [thread overview]
Message-ID: <CZQSPYZUWFGD.1ZLSA295LSM77@bootlin.com> (raw)
In-Reply-To: <yyyhx62wcvro2zrkxmj6g3esg32zh62f4spox7txv4ghc74ewo@lzduga5d4wzi>
Hello,
On Fri Mar 8, 2024 at 11:54 PM CET, Andi Shyti wrote:
> Hi Theo,
>
> > +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> > + unsigned long reg)
>
> If you don't mind, I fixed this checkpatch warning while
> applying:
>
> CHECK: Alignment should match open parenthesis
> #103: FILE: drivers/i2c/busses/i2c-nomadik.c:247:
> +static inline void nmk_i2c_writeb(const struct nmk_i2c_dev *priv, u32 val,
> + unsigned long reg)
Indeed I do not mind. Thanks for the work!
Do ping me if any follow-up is required.
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-11 8:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 17:59 [PATCH v3 00/11] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 01/11] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 19:36 ` Rob Herring
2024-03-06 19:36 ` Rob Herring
2024-03-06 20:17 ` Rob Herring
2024-03-06 20:17 ` Rob Herring
2024-03-06 17:59 ` [PATCH v3 02/11] i2c: nomadik: rename private struct pointers from dev to priv Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 03/11] i2c: nomadik: simplify IRQ masking logic Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-07 23:01 ` Andi Shyti
2024-03-07 23:01 ` Andi Shyti
2024-03-08 8:57 ` Théo Lebrun
2024-03-08 8:57 ` Théo Lebrun
2024-03-08 12:27 ` Andi Shyti
2024-03-08 12:27 ` Andi Shyti
2024-03-08 13:33 ` Théo Lebrun
2024-03-08 13:33 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 04/11] i2c: nomadik: use bitops helpers Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-07 23:04 ` Andi Shyti
2024-03-07 23:04 ` Andi Shyti
2024-03-06 17:59 ` [PATCH v3 05/11] i2c: nomadik: support short xfer timeouts using waitqueue & hrtimer Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 06/11] i2c: nomadik: replace jiffies by ktime for FIFO flushing timeout Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 07/11] i2c: nomadik: fetch i2c-transfer-timeout-us property from devicetree Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-07 23:11 ` Andi Shyti
2024-03-07 23:11 ` Andi Shyti
2024-03-08 9:16 ` Théo Lebrun
2024-03-08 9:16 ` Théo Lebrun
2024-03-08 12:28 ` Andi Shyti
2024-03-08 12:28 ` Andi Shyti
2024-03-08 22:54 ` Andi Shyti
2024-03-08 22:54 ` Andi Shyti
2024-03-11 8:59 ` Théo Lebrun [this message]
2024-03-11 8:59 ` Théo Lebrun
2024-03-06 17:59 ` [PATCH v3 09/11] i2c: nomadik: sort includes Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-06 19:51 ` Linus Walleij
2024-03-06 19:51 ` Linus Walleij
2024-03-07 23:11 ` Andi Shyti
2024-03-07 23:11 ` Andi Shyti
2024-03-06 17:59 ` [PATCH v3 10/11] MIPS: mobileye: eyeq5: add 5 I2C controller nodes Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-08 12:25 ` Andi Shyti
2024-03-08 12:25 ` Andi Shyti
2024-03-06 17:59 ` [PATCH v3 11/11] MIPS: mobileye: eyeq5: add evaluation board I2C temp sensor Théo Lebrun
2024-03-06 17:59 ` Théo Lebrun
2024-03-08 12:26 ` Andi Shyti
2024-03-08 12:26 ` Andi Shyti
2024-03-08 22:52 ` (subset) [PATCH v3 00/11] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Andi Shyti
2024-03-08 22:52 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZQSPYZUWFGD.1ZLSA295LSM77@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.