All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Aapo Vienamo" <aapo.vienamo@linux.intel.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 1/2] mtd: core: Report error if first mtd_otp_size() call fails in mtd_otp_nvmem_add()
Date: Mon, 11 Mar 2024 15:23:39 +0100	[thread overview]
Message-ID: <CZQZM2NMDNGU.1O7L4KJFYGA18@kernel.org> (raw)
In-Reply-To: <20240307130418.3131898-2-aapo.vienamo@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 554 bytes --]

On Thu Mar 7, 2024 at 2:04 PM CET, Aapo Vienamo wrote:
> Jump to the error reporting code in mtd_otp_nvmem_add() if the
> mtd_otp_size() call fails. Without this fix, the error is not logged.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")

Not sure this qualifies as a Fixes patch, I'll leave that to the MTD
mainterainer.

Anyways,
Reviewed-by: Michael Walle <mwalle@kernel.org>

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Aapo Vienamo" <aapo.vienamo@linux.intel.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 1/2] mtd: core: Report error if first mtd_otp_size() call fails in mtd_otp_nvmem_add()
Date: Mon, 11 Mar 2024 15:23:39 +0100	[thread overview]
Message-ID: <CZQZM2NMDNGU.1O7L4KJFYGA18@kernel.org> (raw)
In-Reply-To: <20240307130418.3131898-2-aapo.vienamo@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Thu Mar 7, 2024 at 2:04 PM CET, Aapo Vienamo wrote:
> Jump to the error reporting code in mtd_otp_nvmem_add() if the
> mtd_otp_size() call fails. Without this fix, the error is not logged.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")

Not sure this qualifies as a Fixes patch, I'll leave that to the MTD
mainterainer.

Anyways,
Reviewed-by: Michael Walle <mwalle@kernel.org>

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

  reply	other threads:[~2024-03-11 14:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 13:04 [PATCH 0/2] mtd: core: Handle unsupported OTP operations Aapo Vienamo
2024-03-07 13:04 ` Aapo Vienamo
2024-03-07 13:04 ` [PATCH 1/2] mtd: core: Report error if first mtd_otp_size() call fails in mtd_otp_nvmem_add() Aapo Vienamo
2024-03-07 13:04   ` Aapo Vienamo
2024-03-11 14:23   ` Michael Walle [this message]
2024-03-11 14:23     ` Michael Walle
2024-03-07 13:04 ` [PATCH 2/2] mtd: core: Don't fail mtd_device_parse_register() if OTP is unsupported Aapo Vienamo
2024-03-07 13:04   ` Aapo Vienamo
2024-03-11 14:38   ` Michael Walle
2024-03-11 14:38     ` Michael Walle
2024-03-11 16:20     ` Aapo Vienamo
2024-03-11 16:20       ` Aapo Vienamo
2024-03-13  9:24       ` Michael Walle
2024-03-13  9:24         ` Michael Walle
2024-03-13 13:59         ` Aapo Vienamo
2024-03-13 13:59           ` Aapo Vienamo
2024-03-13 14:03           ` Michael Walle
2024-03-13 14:03             ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CZQZM2NMDNGU.1O7L4KJFYGA18@kernel.org \
    --to=mwalle@kernel.org \
    --cc=aapo.vienamo@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.