From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>, <mpe@ellerman.id.au>,
<linux-integrity@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>
Cc: <linux-kernel@vger.kernel.org>, <rnsastry@linux.ibm.com>,
<peterhuewe@gmx.de>, <viparash@in.ibm.com>,
<devicetree@vger.kernel.org>, <jsnitsel@redhat.com>
Subject: Re: [RFC PATCH v2 3/3] tpm: of: If available use linux,sml-log to get the log and its size
Date: Mon, 11 Mar 2024 22:25:29 +0200 [thread overview]
Message-ID: <CZR7B45P71XS.53XNZD9FWZSL@kernel.org> (raw)
In-Reply-To: <20240311132030.1103122-4-stefanb@linux.ibm.com>
On Mon Mar 11, 2024 at 3:20 PM EET, Stefan Berger wrote:
> If linux,sml-log is available use it to get the TPM log rather than the
> pointer found in linux,sml-base. This resolves an issue on PowerVM and KVM
> on Power where after a kexec the memory pointed to by linux,sml-base may
> have become inaccessible or corrupted. Also, linux,sml-log has replaced
> linux,sml-base and linux,sml-size on these two platforms.
>
> Keep the handling of linux,sml-base/sml-size for powernv platforms that
> provide the two properties via skiboot.
>
> Fixes: c5df39262dd5 ("drivers/char/tpm: Add securityfs support for event log")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
I'm worried about not being up to date and instead using "cached" values
when verifying anything from a security chip. Does this guarantee that
TPM log is corrupted and will not get updated somehow?
BR, Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>, <mpe@ellerman.id.au>,
<linux-integrity@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>
Cc: devicetree@vger.kernel.org, rnsastry@linux.ibm.com,
jsnitsel@redhat.com, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, viparash@in.ibm.com
Subject: Re: [RFC PATCH v2 3/3] tpm: of: If available use linux,sml-log to get the log and its size
Date: Mon, 11 Mar 2024 22:25:29 +0200 [thread overview]
Message-ID: <CZR7B45P71XS.53XNZD9FWZSL@kernel.org> (raw)
In-Reply-To: <20240311132030.1103122-4-stefanb@linux.ibm.com>
On Mon Mar 11, 2024 at 3:20 PM EET, Stefan Berger wrote:
> If linux,sml-log is available use it to get the TPM log rather than the
> pointer found in linux,sml-base. This resolves an issue on PowerVM and KVM
> on Power where after a kexec the memory pointed to by linux,sml-base may
> have become inaccessible or corrupted. Also, linux,sml-log has replaced
> linux,sml-base and linux,sml-size on these two platforms.
>
> Keep the handling of linux,sml-base/sml-size for powernv platforms that
> provide the two properties via skiboot.
>
> Fixes: c5df39262dd5 ("drivers/char/tpm: Add securityfs support for event log")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
I'm worried about not being up to date and instead using "cached" values
when verifying anything from a security chip. Does this guarantee that
TPM log is corrupted and will not get updated somehow?
BR, Jarkko
next prev parent reply other threads:[~2024-03-11 20:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:20 [RFC PATCH v2 0/3] Preserve TPM log across kexec Stefan Berger
2024-03-11 13:20 ` Stefan Berger
2024-03-11 13:20 ` [RFC PATCH v2 1/3] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log Stefan Berger
2024-03-11 13:20 ` Stefan Berger
2024-03-11 17:24 ` Christophe Leroy
2024-03-11 19:10 ` Stefan Berger
2024-03-11 17:47 ` Jerry Snitselaar
2024-03-11 17:47 ` Jerry Snitselaar
2024-03-11 20:21 ` Jarkko Sakkinen
2024-03-11 20:21 ` Jarkko Sakkinen
2024-03-11 13:20 ` [RFC PATCH v2 2/3] dt-bindings: tpm: Add linux,sml-log to ibm,vtpm.yaml Stefan Berger
2024-03-11 13:20 ` Stefan Berger
2024-03-12 11:11 ` Lukas Wunner
2024-03-12 11:11 ` Lukas Wunner
2024-03-12 14:12 ` Stefan Berger
2024-03-12 14:12 ` Stefan Berger
2024-03-12 15:52 ` Jarkko Sakkinen
2024-03-12 15:52 ` Jarkko Sakkinen
2024-03-11 13:20 ` [RFC PATCH v2 3/3] tpm: of: If available use linux,sml-log to get the log and its size Stefan Berger
2024-03-11 13:20 ` Stefan Berger
2024-03-11 20:25 ` Jarkko Sakkinen [this message]
2024-03-11 20:25 ` Jarkko Sakkinen
2024-03-11 20:33 ` Stefan Berger
2024-03-11 20:33 ` Stefan Berger
2024-03-12 15:43 ` Jarkko Sakkinen
2024-03-12 15:43 ` Jarkko Sakkinen
2024-03-12 19:37 ` Stefan Berger
2024-03-12 19:37 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZR7B45P71XS.53XNZD9FWZSL@kernel.org \
--to=jarkko@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=peterhuewe@gmx.de \
--cc=rnsastry@linux.ibm.com \
--cc=stefanb@linux.ibm.com \
--cc=viparash@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.