All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Masami Hiramatsu" <mhiramat@kernel.org>
Cc: <linux-riscv@lists.infradead.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	<linux-kernel@vger.kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	<linux-modules@vger.kernel.org>,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	"Anil S Keshavamurthy" <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 1/2] kprobes: textmem API
Date: Tue, 26 Mar 2024 19:02:35 +0200	[thread overview]
Message-ID: <D03UDXV4OKIK.5HOOVU4LDW5D@kernel.org> (raw)
In-Reply-To: <20240327000520.ec13b2646ed1cd621e5b1d9d@kernel.org>

On Tue Mar 26, 2024 at 5:05 PM EET, Masami Hiramatsu (Google) wrote:
> > According to kconfig-language.txt:
> > 
> > "select should be used with care. select will force a symbol to a value
> > without visiting the dependencies."
> > 
> > So the problem here lies in KPROBES config entry using select statement
> > to pick ALLOC_EXECMEM. It will not take the depends on statement into
> > account and thus will allow to select kprobes without any allocator in
> > place.
>
> OK, in that case "depend on" is good.

Yeah, did not remember this at all. Only recalled when I started to
get linking errors when compiling just the first patch... It's a bit
uninituitive twist in kconfig :-)

BR, Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Masami Hiramatsu" <mhiramat@kernel.org>
Cc: <linux-riscv@lists.infradead.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	<linux-kernel@vger.kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	<linux-modules@vger.kernel.org>,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	"Anil S Keshavamurthy" <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 1/2] kprobes: textmem API
Date: Tue, 26 Mar 2024 19:02:35 +0200	[thread overview]
Message-ID: <D03UDXV4OKIK.5HOOVU4LDW5D@kernel.org> (raw)
In-Reply-To: <20240327000520.ec13b2646ed1cd621e5b1d9d@kernel.org>

On Tue Mar 26, 2024 at 5:05 PM EET, Masami Hiramatsu (Google) wrote:
> > According to kconfig-language.txt:
> > 
> > "select should be used with care. select will force a symbol to a value
> > without visiting the dependencies."
> > 
> > So the problem here lies in KPROBES config entry using select statement
> > to pick ALLOC_EXECMEM. It will not take the depends on statement into
> > account and thus will allow to select kprobes without any allocator in
> > place.
>
> OK, in that case "depend on" is good.

Yeah, did not remember this at all. Only recalled when I started to
get linking errors when compiling just the first patch... It's a bit
uninituitive twist in kconfig :-)

BR, Jarkko

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-03-26 17:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 21:55 [PATCH v5 1/2] kprobes: textmem API Jarkko Sakkinen
2024-03-25 21:55 ` Jarkko Sakkinen
2024-03-25 21:55 ` [PATCH v5 2/2] arch/riscv: Enable kprobes when CONFIG_MODULES=n Jarkko Sakkinen
2024-03-25 21:55   ` Jarkko Sakkinen
2024-03-26 13:57   ` Alexandre Ghiti
2024-03-26 13:57     ` Alexandre Ghiti
2024-03-26 16:49     ` Jarkko Sakkinen
2024-03-26 16:49       ` Jarkko Sakkinen
2024-03-26 16:54       ` Jarkko Sakkinen
2024-03-26 16:54         ` Jarkko Sakkinen
2024-03-26 19:03       ` Alexandre Ghiti
2024-03-26 19:03         ` Alexandre Ghiti
2024-03-25 22:06 ` [PATCH v5 1/2] kprobes: textmem API Jarkko Sakkinen
2024-03-25 22:06   ` Jarkko Sakkinen
2024-03-25 22:09 ` Jarkko Sakkinen
2024-03-25 22:09   ` Jarkko Sakkinen
2024-03-25 22:16   ` Jarkko Sakkinen
2024-03-25 22:16     ` Jarkko Sakkinen
2024-03-25 23:50   ` Masami Hiramatsu
2024-03-25 23:50     ` Masami Hiramatsu
2024-03-26  0:36     ` Jarkko Sakkinen
2024-03-26  0:36       ` Jarkko Sakkinen
2024-03-26  0:58 ` Masami Hiramatsu
2024-03-26  0:58   ` Masami Hiramatsu
2024-03-26  1:31   ` Jarkko Sakkinen
2024-03-26  1:31     ` Jarkko Sakkinen
2024-03-26  2:01     ` Jarkko Sakkinen
2024-03-26  2:01       ` Jarkko Sakkinen
2024-03-26 13:18       ` Jarkko Sakkinen
2024-03-26 13:18         ` Jarkko Sakkinen
2024-03-26 15:05         ` Masami Hiramatsu
2024-03-26 15:05           ` Masami Hiramatsu
2024-03-26 17:02           ` Jarkko Sakkinen [this message]
2024-03-26 17:02             ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D03UDXV4OKIK.5HOOVU4LDW5D@kernel.org \
    --to=jarkko@kernel.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.