All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit 294b91a5817147d4b7f47be2ac69bac2a1f26491 broke mpc85xx
Date: Wed, 1 Oct 2014 04:06:30 +0000	[thread overview]
Message-ID: <D050CBD4.18CFA%yorksun@freescale.com> (raw)

Simon,

I didn't notice until today the commit
294b91a5817147d4b7f47be2ac69bac2a1f26491 broke at least T4240QDS. I have
narrowed down to these two lines in common/board_r.c

initr_barrier,
        initr_malloc,

If I move these two lines below this part


#if defined(CONFIG_SYS_INIT_RAM_LOCK) && defined(CONFIG_E500)
        initr_unlock_ram_in_cache,
#endif


U-boot boots OK on T4240QDS (I can see the prompt). But if I move them
anywhere above this initr_unlock_ram_in_cache, it hangs the core when
initializing PCI. It may break other mpc85xx platforms but I didn't have
time to check more today. I haven't figured out why you have to move these
two lines up. Please take a close look.

Thanks,

York

             reply	other threads:[~2014-10-01  4:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01  4:06 York Sun [this message]
2014-10-01 15:11 ` [U-Boot] Commit 294b91a5817147d4b7f47be2ac69bac2a1f26491 broke mpc85xx Simon Glass
2014-10-01 16:27   ` York Sun
2014-10-01 16:37     ` Simon Glass
2014-10-01 16:52       ` York Sun
2014-10-01 18:01         ` Simon Glass
2014-10-01 18:25           ` York Sun
2014-10-02  2:15     ` Scott Wood
2014-10-02  3:29       ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D050CBD4.18CFA%yorksun@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.