From: "Nicholas Piggin" <npiggin@gmail.com>
To: "BALATON Zoltan" <balaton@eik.bme.hu>
Cc: <qemu-devel@nongnu.org>, <qemu-ppc@nongnu.org>,
"Peter Maydell" <peter.maydell@linaro.org>, <philmd@linaro.org>
Subject: Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus
Date: Tue, 16 Apr 2024 12:26:38 +1000 [thread overview]
Message-ID: <D0L6WPE1ASIP.2KG5P0WQ86AM6@gmail.com> (raw)
In-Reply-To: <887fc804-54a6-8f00-1b62-afcf247ba319@eik.bme.hu>
On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote:
> On Wed, 10 Apr 2024, Nicholas Piggin wrote:
> > On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote:
> >> Real 460EX SoC apparently does not expose a bridge device and having
> >> it appear on PCI bus confuses an AmigaOS file system driver that uses
> >> this to detect which machine it is running on. Since values written
> >> here by firmware are never read, just ignore these writes and drop the
> >> bridge device.
> >>
> >> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> >> ---
> >> This is only used by sam460ex and this fixes an issue with AmigaOS on
> >> this machine so I'd like this to be merged for 9.0 please.
> >
> > Is it a regression? Does it have a fixes: or resolves: tag?
> >
> > Unless we broke it in this cycle, I would be inclined to wait,
> > and we can ask to put it in stable.
>
> It's not something that broke in this cycle but since this does not affect
> anything else than sam460ex I think it's OK to change this for 9.0. The
> changes to 440 tlb in this cycle made sam460ex more useful to run AmigaOS
> and this fixes the file system driver on it so it would make 9.0 really
> usable. Otherwise people would have to wait longer until August or install
> a stable update. Since this has low chance to break anything (tested with
> AmogaOS and Linux and MorphOS does not boot due to do_io changes anyway) I
> don't think we have to wait with this.
Hey, travelling / at a conference / on vacation for the next couple of
weeks.
It's just a bit late for hard freeze IMO, since we didn't break it
before the prior release or a bad security / crash bug. Will put it in
9.1.
Thanks,
Nick
next prev parent reply other threads:[~2024-04-16 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 23:55 [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus BALATON Zoltan
2024-04-10 4:38 ` Nicholas Piggin
2024-04-10 11:03 ` BALATON Zoltan
2024-04-16 2:26 ` Nicholas Piggin [this message]
2024-04-16 9:43 ` BALATON Zoltan
2024-04-17 2:09 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0L6WPE1ASIP.2KG5P0WQ86AM6@gmail.com \
--to=npiggin@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.