From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Shivaprasad G Bhat" <sbhat@linux.ibm.com>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
Cc: <pbonzini@redhat.com>, <naveen.n.rao@linux.ibm.com>,
<christophe.leroy@csgroup.eu>, <corbet@lwn.net>,
<mpe@ellerman.id.au>, <namhyung@kernel.org>,
<pbonzini@redhat.com>, <jniethe5@gmail.com>,
<atrajeev@linux.vnet.ibm.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/8] KVM: PPC: Book3S HV: Nested guest migration fixes
Date: Thu, 06 Jun 2024 13:06:26 +1000 [thread overview]
Message-ID: <D1SLOYCQGIQ6.17Y5C9XJDHX33@gmail.com> (raw)
In-Reply-To: <171759276071.1480.9356137231993600304.stgit@linux.ibm.com>
On Wed Jun 5, 2024 at 11:06 PM AEST, Shivaprasad G Bhat wrote:
> The series fixes the issues exposed by the kvm-unit-tests[1]
> sprs-migration test.
>
> The SDAR, MMCR3 were seen to have some typo/refactoring bugs.
> The first two patches fix them.
>
> The remaining patches take care of save-restoring the guest
> state elements for DEXCR, HASHKEYR and HASHPKEYR SPRs with PHYP
> during entry-exit. The KVM_PPC_REG too for them are missing which
> are added for use by the QEMU.
These and the qemu patches all look good now. I'll give them
some testing and send R-B in the next day or two. I'm trying
to write a k-u-t for the hashpkey migration case...
Thanks,
Nick
>
> References:
> [1]: https://github.com/kvm-unit-tests/kvm-unit-tests
>
> ---
>
> Changelog:
> v1: https://lore.kernel.org/kvm/171741555734.11675.17428208097186191736.stgit@c0c876608f2d/
> - Reordered the patches in a way to introduce the SPRs first as
> suggested.
> - Added Reviewed-bys to the reviewed ones.
> - Added 2 more patches to handle the hashpkeyr state
>
> Shivaprasad G Bhat (8):
> KVM: PPC: Book3S HV: Fix the set_one_reg for MMCR3
> KVM: PPC: Book3S HV: Fix the get_one_reg of SDAR
> KVM: PPC: Book3S HV: Add one-reg interface for DEXCR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest DEXCR in sync
> KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHKEYR in sync
> KVM: PPC: Book3S HV: Add one-reg interface for HASHPKEYR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHPKEYR in sync
>
>
> Documentation/virt/kvm/api.rst | 3 +++
> arch/powerpc/include/asm/kvm_host.h | 3 +++
> arch/powerpc/include/uapi/asm/kvm.h | 3 +++
> arch/powerpc/kvm/book3s_hv.c | 22 ++++++++++++++++++++--
> arch/powerpc/kvm/book3s_hv.h | 3 +++
> arch/powerpc/kvm/book3s_hv_nestedv2.c | 18 ++++++++++++++++++
> 6 files changed, 50 insertions(+), 2 deletions(-)
>
> --
> Signature
WARNING: multiple messages have this Message-ID (diff)
From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Shivaprasad G Bhat" <sbhat@linux.ibm.com>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
Cc: atrajeev@linux.vnet.ibm.com, corbet@lwn.net,
linux-kernel@vger.kernel.org, namhyung@kernel.org,
naveen.n.rao@linux.ibm.com, pbonzini@redhat.com,
jniethe5@gmail.com
Subject: Re: [PATCH v2 0/8] KVM: PPC: Book3S HV: Nested guest migration fixes
Date: Thu, 06 Jun 2024 13:06:26 +1000 [thread overview]
Message-ID: <D1SLOYCQGIQ6.17Y5C9XJDHX33@gmail.com> (raw)
In-Reply-To: <171759276071.1480.9356137231993600304.stgit@linux.ibm.com>
On Wed Jun 5, 2024 at 11:06 PM AEST, Shivaprasad G Bhat wrote:
> The series fixes the issues exposed by the kvm-unit-tests[1]
> sprs-migration test.
>
> The SDAR, MMCR3 were seen to have some typo/refactoring bugs.
> The first two patches fix them.
>
> The remaining patches take care of save-restoring the guest
> state elements for DEXCR, HASHKEYR and HASHPKEYR SPRs with PHYP
> during entry-exit. The KVM_PPC_REG too for them are missing which
> are added for use by the QEMU.
These and the qemu patches all look good now. I'll give them
some testing and send R-B in the next day or two. I'm trying
to write a k-u-t for the hashpkey migration case...
Thanks,
Nick
>
> References:
> [1]: https://github.com/kvm-unit-tests/kvm-unit-tests
>
> ---
>
> Changelog:
> v1: https://lore.kernel.org/kvm/171741555734.11675.17428208097186191736.stgit@c0c876608f2d/
> - Reordered the patches in a way to introduce the SPRs first as
> suggested.
> - Added Reviewed-bys to the reviewed ones.
> - Added 2 more patches to handle the hashpkeyr state
>
> Shivaprasad G Bhat (8):
> KVM: PPC: Book3S HV: Fix the set_one_reg for MMCR3
> KVM: PPC: Book3S HV: Fix the get_one_reg of SDAR
> KVM: PPC: Book3S HV: Add one-reg interface for DEXCR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest DEXCR in sync
> KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHKEYR in sync
> KVM: PPC: Book3S HV: Add one-reg interface for HASHPKEYR register
> KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHPKEYR in sync
>
>
> Documentation/virt/kvm/api.rst | 3 +++
> arch/powerpc/include/asm/kvm_host.h | 3 +++
> arch/powerpc/include/uapi/asm/kvm.h | 3 +++
> arch/powerpc/kvm/book3s_hv.c | 22 ++++++++++++++++++++--
> arch/powerpc/kvm/book3s_hv.h | 3 +++
> arch/powerpc/kvm/book3s_hv_nestedv2.c | 18 ++++++++++++++++++
> 6 files changed, 50 insertions(+), 2 deletions(-)
>
> --
> Signature
next prev parent reply other threads:[~2024-06-06 3:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:06 [PATCH v2 0/8] KVM: PPC: Book3S HV: Nested guest migration fixes Shivaprasad G Bhat
2024-06-05 13:06 ` Shivaprasad G Bhat
2024-06-05 13:06 ` [PATCH v2 1/8] KVM: PPC: Book3S HV: Fix the set_one_reg for MMCR3 Shivaprasad G Bhat
2024-06-05 13:06 ` Shivaprasad G Bhat
2024-06-05 13:06 ` [PATCH v2 2/8] KVM: PPC: Book3S HV: Fix the get_one_reg of SDAR Shivaprasad G Bhat
2024-06-05 13:06 ` Shivaprasad G Bhat
2024-06-05 13:06 ` [PATCH v2 3/8] KVM: PPC: Book3S HV: Add one-reg interface for DEXCR register Shivaprasad G Bhat
2024-06-05 13:06 ` Shivaprasad G Bhat
2024-06-05 13:07 ` [PATCH v2 4/8] KVM: PPC: Book3S HV nestedv2: Keep nested guest DEXCR in sync Shivaprasad G Bhat
2024-06-05 13:07 ` Shivaprasad G Bhat
2024-06-05 13:07 ` [PATCH v2 5/8] KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register Shivaprasad G Bhat
2024-06-05 13:07 ` Shivaprasad G Bhat
2024-06-05 13:07 ` [PATCH v2 6/8] KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHKEYR in sync Shivaprasad G Bhat
2024-06-05 13:07 ` Shivaprasad G Bhat
2024-06-05 13:07 ` [PATCH v2 7/8] KVM: PPC: Book3S HV: Add one-reg interface for HASHPKEYR register Shivaprasad G Bhat
2024-06-05 13:07 ` Shivaprasad G Bhat
2024-06-05 13:07 ` [PATCH v2 8/8] KVM: PPC: Book3S HV nestedv2: Keep nested guest HASHPKEYR in sync Shivaprasad G Bhat
2024-06-05 13:07 ` Shivaprasad G Bhat
2024-06-06 3:06 ` Nicholas Piggin [this message]
2024-06-06 3:06 ` [PATCH v2 0/8] KVM: PPC: Book3S HV: Nested guest migration fixes Nicholas Piggin
2024-06-20 14:29 ` Michael Ellerman
2024-06-20 14:29 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1SLOYCQGIQ6.17Y5C9XJDHX33@gmail.com \
--to=npiggin@gmail.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=jniethe5@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=sbhat@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.