All of lore.kernel.org
 help / color / mirror / Atom feed
* [lustre-devel] layout.c capsule dumps
@ 2015-10-22 15:58 Ben Evans
  2015-10-22 16:10 ` Dilger, Andreas
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Evans @ 2015-10-22 15:58 UTC (permalink / raw)
  To: lustre-devel

Are these completely unused at this point?  As far as I can tell, the main mechanism to dump info, req_capsule_(client|server)_dump are completely unreferenced by anything.

Would it make sense to remove all this as dead code, or am I missing something?

-Ben Evans
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20151022/6215e695/attachment.htm>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [lustre-devel] layout.c capsule dumps
  2015-10-22 15:58 [lustre-devel] layout.c capsule dumps Ben Evans
@ 2015-10-22 16:10 ` Dilger, Andreas
  0 siblings, 0 replies; 2+ messages in thread
From: Dilger, Andreas @ 2015-10-22 16:10 UTC (permalink / raw)
  To: lustre-devel

They are only for debugging. Probably best to put them under CONFIG_DEBUG_LUSTRE_EXPENSIVE_CHECKS or some new CONFIG option. 

Cheers, Andreas

> On Oct 22, 2015, at 09:58, Ben Evans <bevans@cray.com> wrote:
> 
> Are these completely unused at this point?  As far as I can tell, the main mechanism to dump info, req_capsule_(client|server)_dump are completely unreferenced by anything.
> 
> Would it make sense to remove all this as dead code, or am I missing something?
> 
> -Ben Evans
> _______________________________________________
> lustre-devel mailing list
> lustre-devel at lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-22 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 15:58 [lustre-devel] layout.c capsule dumps Ben Evans
2015-10-22 16:10 ` Dilger, Andreas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.