Re: [meta-arago][scarthgap/master][PATCH] vulkan-cts: add workaround for createMeshShaderMiscTestsEXT

Re: [meta-arago][scarthgap/master][PATCH] vulkan-cts: add workaround for createMeshShaderMiscTestsEXT

[Randolph Sapp]

On Fri Jun 21, 2024 at 4:49 PM CDT, Randolph Sapp via lists.yoctoproject.org wrote:
> From: Randolph Sapp <rs@ti.com>
>
> Remove the CXX flag "-O2" for GCC 13 and 14 on aarch64 platforms.
> There's a bug with ARM GCC that breaks the iteration of "types" in the
> createMeshShaderMiscTestsEXT function. This issue is not present for
> clang or x86_64 GCC 14.
>
> It seems that the array is not initialized before the first iteration.
> In testing this can result in a random value being used. This can
> manifest in LINES type being processed twice, resulting in the following
> error:
>
> FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name
> 'no_lines' added to group 'misc'.
>
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>
> Taking too long for this to hit master so the backport probably won't come in
> time for scarthgap. Submitting this in the meantime.
>
>  .../recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend      | 2 ++
>  1 file changed, 2 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend
>
> diff --git a/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend b/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend
> new file mode 100644
> index 00000000..7af2057f
> --- /dev/null
> +++ b/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend
> @@ -0,0 +1,2 @@
> +# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
> +OECMAKE_CXX_FLAGS:remove:toolchain-gcc:aarch64 = "-O2"

Don't worry about this patch anymore. The guys in meta-openembedded pulled my
backport already.

- Randolph

[meta-arago][scarthgap/master][PATCH] vulkan-cts: add workaround for createMeshShaderMiscTestsEXT

[rs]

From: Randolph Sapp <rs@ti.com>

Remove the CXX flag "-O2" for GCC 13 and 14 on aarch64 platforms.
There's a bug with ARM GCC that breaks the iteration of "types" in the
createMeshShaderMiscTestsEXT function. This issue is not present for
clang or x86_64 GCC 14.

It seems that the array is not initialized before the first iteration.
In testing this can result in a random value being used. This can
manifest in LINES type being processed twice, resulting in the following
error:

FATAL ERROR: Failed to initialize dEQP: Test case with non-unique name
'no_lines' added to group 'misc'.

Signed-off-by: Randolph Sapp <rs@ti.com>
---

Taking too long for this to hit master so the backport probably won't come in
time for scarthgap. Submitting this in the meantime.

 .../recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend      | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend

diff --git a/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend b/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend
new file mode 100644
index 00000000..7af2057f
--- /dev/null
+++ b/meta-arago-distro/recipes-graphics/vk-gl-cts/vulkan-cts_1.3.7.3.bbappend
@@ -0,0 +1,2 @@
+# Workaround an optimization bug that breaks createMeshShaderMiscTestsEXT
+OECMAKE_CXX_FLAGS:remove:toolchain-gcc:aarch64 = "-O2"
-- 
2.45.1