Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Detlev Casanova" <detlev.casanova@collabora.com>,
	"Chukun Pan" <amadeus@jmu.edu.cn>
Cc: <airlied@gmail.com>, <alchark@gmail.com>, <andi.shyti@kernel.org>,
	<andyshrk@163.com>, <broonie@kernel.org>, <cl@rock-chips.com>,
	<conor+dt@kernel.org>, <daniel@ffwll.ch>,
	<devicetree@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<dsimic@manjaro.org>, <efectn@protonmail.com>,
	<finley.xiao@rock-chips.com>, <gregkh@linuxfoundation.org>,
	<heiko@sntech.de>, <honyuenkwun@gmail.com>, <jagan@edgeble.ai>,
	<jamie@jamieiles.com>, <jic23@kernel.org>, <jirislaby@kernel.org>,
	<jonas@kwiboo.se>, <jszhang@kernel.org>, <kernel@collabora.com>,
	<krzk+dt@kernel.org>, <lars@metafoo.de>, <lee@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-i2c@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-serial@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<linux-watchdog@vger.kernel.org>, <linux@roeck-us.net>,
	<maarten.lankhorst@linux.intel.com>, <macromorgan@hotmail.com>,
	<megi@xff.cz>, <michael.riesch@wolfvision.net>,
	<mripard@kernel.org>, <robh@kernel.org>, <tim@feathertop.org>,
	<tzimmermann@suse.de>, <ulf.hansson@linaro.org>,
	<wim@linux-watchdog.org>
Subject: Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT
Date: Mon, 26 Aug 2024 21:56:34 +0200	[thread overview]
Message-ID: <D3Q3WI8AHRJ1.3B8E985JAVVC2@cknow.org> (raw)
In-Reply-To: <22403959.EfDdHjke4D@bootstrap>

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Mon Aug 26, 2024 at 8:28 PM CEST, Detlev Casanova wrote:
> On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote:
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> > > ...
> > > +		opp-1416000000 {
> > > +			opp-hz = /bits/ 64 <1416000000>;
> > > +			opp-microvolt = <725000 725000 950000>;
> > > +			opp-microvolt-L1 = <712500 712500 950000>;
> > > +			opp-microvolt-L2 = <700000 700000 950000>;
> > > +			opp-microvolt-L3 = <700000 700000 950000>;
> > > +			opp-microvolt-L4 = <700000 700000 950000>;
> > > +			opp-microvolt-L5 = <700000 700000 950000>;
> > > +			clock-latency-ns = <40000>;
> > > +		};
> > > ...
> > 
> > I'm curious if these frequencies work properly. On the bsp kernel,
> > 'opp-microvolt-L<name>' is used by the PVTM driver, I don't know
> > if it works on the upstream kernel.
>
> Which seems to correspond to the set opp-hz value. As mentionned by Alexey, 
> the opp-microvolt-L.* values are not used by the driver.
>
> I also have not tested any cpufreq settings/driver on this board yet. I can 
> remove the opp-microvolt-L.* for now.

If you run this command on the upstream kernel:
``grep -r "opp-microvolt" arch/arm64/boot/dts/rockchip/``

you'll see it doesn't use the opp-microvolt-LN variants anywhere,
so this is indeed a downstream/BSP only thing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]