Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash

From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"AlvinZhou" <alvinzhou.tw@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <pratyush@kernel.org>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<broonie@kernel.org>
Cc: <chengminglin@mxic.com.tw>, <leoyu@mxic.com.tw>,
	"AlvinZhou" <alvinzhou@mxic.com.tw>,
	"JaimeLiao" <jaimeliao@mxic.com.tw>,
	"Bough Chen" <haibo.chen@nxp.com>
Subject: Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash
Date: Mon, 23 Sep 2024 09:18:01 +0200	[thread overview]
Message-ID: <D4DHAZ1MIJV2.1G810GI4K5DVV@kernel.org> (raw)
In-Reply-To: <97134efb-398d-4c21-a915-87a5b4f1b29a@linaro.org>

Hi,

> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = {
> >  		.name = "mx25l3255e",
> >  		.size = SZ_4M,
> >  		.no_sfdp_flags = SECT_4K,
> > -	}
> > +	},
> > +	/* Need the manufacturer fixups, Keep this last */
> > +	{ .id = SNOR_ID(0xc2) }
> >  };
> >  
>
> Could you please elaborate why you need just the manufacturer id here? I
> would have expected to see a specific flash entry instead.

I can't find the thread anymore as this is going on for forever, but
that was my suggestion. That's a catch all to have the manufacturer
fixup applied for any macronix flashes instead of having to list
each flash id here.

-michael