All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<devicetree@vger.kernel.org>, <imx@lists.linux.dev>,
	"Richard Weinberger" <richard@nod.at>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	<linux-kernel@vger.kernel.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-mtd@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
	"Pratyush Yadav" <pratyush@kernel.org>
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator
Date: Mon, 07 Oct 2024 09:50:39 +0200	[thread overview]
Message-ID: <D4PERKZ4GL6B.1WKA1I3MYSQVL@kernel.org> (raw)
In-Reply-To: <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hi,

> > > +	ret = devm_regulator_get_enable(dev, "vcc");
> > > +	if (ret)
> > > +		return ret;
> > > +
> > 
> > What happens if the SPI-NOR doesn't have a "vcc" regulator?
>
> ...the SPI-NOR will use the dummy regulator.

Which then prints a warning "using dummy regulator". Is that the
usual way to go?
I mean the regulator is actually mandatory because it is the main
voltage rail for the flash. To get rid of the warning one can add a
fixed-regulator (which is correct anyway). But OTOH, the device tree
lists it as optional (marking it as required isn't an option either
because virtually all device trees won't have that property).

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	<devicetree@vger.kernel.org>, <imx@lists.linux.dev>,
	"Richard Weinberger" <richard@nod.at>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	<linux-kernel@vger.kernel.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-mtd@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
	"Pratyush Yadav" <pratyush@kernel.org>
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator
Date: Mon, 07 Oct 2024 09:50:39 +0200	[thread overview]
Message-ID: <D4PERKZ4GL6B.1WKA1I3MYSQVL@kernel.org> (raw)
In-Reply-To: <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 668 bytes --]

Hi,

> > > +	ret = devm_regulator_get_enable(dev, "vcc");
> > > +	if (ret)
> > > +		return ret;
> > > +
> > 
> > What happens if the SPI-NOR doesn't have a "vcc" regulator?
>
> ...the SPI-NOR will use the dummy regulator.

Which then prints a warning "using dummy regulator". Is that the
usual way to go?
I mean the regulator is actually mandatory because it is the main
voltage rail for the flash. To get rid of the warning one can add a
fixed-regulator (which is correct anyway). But OTOH, the device tree
lists it as optional (marking it as required isn't an option either
because virtually all device trees won't have that property).

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-10-07  7:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30  9:22 [PATCH v2 0/3] spi-nor: add optional vcc-supply and enable it for i.MX93 Peng Fan (OSS)
2024-09-30  9:22 ` Peng Fan (OSS)
2024-09-30  9:22 ` [PATCH v2 1/3] dt-bindings: mtd: jedec,spi-nor: add optional vcc-supply Peng Fan (OSS)
2024-09-30  9:22   ` Peng Fan (OSS)
2024-09-30  9:18   ` Miquel Raynal
2024-09-30  9:18     ` Miquel Raynal
2024-10-06  0:39     ` Peng Fan
2024-10-06  0:39       ` Peng Fan
2024-09-30  9:22 ` [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator Peng Fan (OSS)
2024-09-30  9:22   ` Peng Fan (OSS)
2024-09-30  9:19   ` Miquel Raynal
2024-09-30  9:19     ` Miquel Raynal
2024-09-30  9:36     ` Marco Felsch
2024-09-30  9:36       ` Marco Felsch
2024-09-30  9:21   ` Marc Kleine-Budde
2024-09-30  9:21     ` Marc Kleine-Budde
2024-09-30  9:25     ` Marc Kleine-Budde
2024-09-30  9:25       ` Marc Kleine-Budde
2024-10-07  7:50       ` Michael Walle [this message]
2024-10-07  7:50         ` Michael Walle
2024-10-29  9:50         ` Tudor Ambarus
2024-10-29  9:50           ` Tudor Ambarus
2024-09-30  9:22 ` [PATCH v2 3/3] arm64: dts: imx93-11x11-evk: add overlays for flexspi flash Peng Fan (OSS)
2024-09-30  9:22   ` Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D4PERKZ4GL6B.1WKA1I3MYSQVL@kernel.org \
    --to=mwalle@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=miquel.raynal@bootlin.com \
    --cc=mkl@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.