* [PATCH] x86/ucode: Explain what microcode_set_module() does
@ 2024-10-23 12:28 Andrew Cooper
2024-10-23 13:59 ` Alejandro Vallejo
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2024-10-23 12:28 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Jan Beulich, Roger Pau Monné
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
I found this hiding in other microcode changes, and decided it was high time
it got included.
---
xen/arch/x86/cpu/microcode/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 8564e4d2c94c..dc2c064cf176 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -108,6 +108,10 @@ static bool ucode_in_nmi = true;
/* Protected by microcode_mutex */
static const struct microcode_patch *microcode_cache;
+/*
+ * Used by the EFI path only, when xen.cfg identifies an explicit microcode
+ * file. Overrides ucode=<int>|scan on the regular command line.
+ */
void __init microcode_set_module(unsigned int idx)
{
ucode_mod_idx = idx;
base-commit: be84e7fe58b51f6b6dd907a038f0ef998a1e281e
prerequisite-patch-id: ef20898eb25a7ca1ea2d7b1d676f00b91b46d5f6
prerequisite-patch-id: e0d0c0acbe4864a00451187ef7232dcaf10b2477
prerequisite-patch-id: f6010b4a6e0b43ac837aea470b3b5e5f390ee3b2
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86/ucode: Explain what microcode_set_module() does
2024-10-23 12:28 [PATCH] x86/ucode: Explain what microcode_set_module() does Andrew Cooper
@ 2024-10-23 13:59 ` Alejandro Vallejo
0 siblings, 0 replies; 2+ messages in thread
From: Alejandro Vallejo @ 2024-10-23 13:59 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Jan Beulich, Roger Pau Monné
On Wed Oct 23, 2024 at 1:28 PM BST, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
With a single nit that I don't care much about, but...
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
>
> I found this hiding in other microcode changes, and decided it was high time
> it got included.
> ---
> xen/arch/x86/cpu/microcode/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
> index 8564e4d2c94c..dc2c064cf176 100644
> --- a/xen/arch/x86/cpu/microcode/core.c
> +++ b/xen/arch/x86/cpu/microcode/core.c
> @@ -108,6 +108,10 @@ static bool ucode_in_nmi = true;
> /* Protected by microcode_mutex */
> static const struct microcode_patch *microcode_cache;
>
> +/*
> + * Used by the EFI path only, when xen.cfg identifies an explicit microcode
> + * file. Overrides ucode=<int>|scan on the regular command line.
> + */
... this it would be better at the interface in microcode.h, imo.
> void __init microcode_set_module(unsigned int idx)
> {
> ucode_mod_idx = idx;
>
> base-commit: be84e7fe58b51f6b6dd907a038f0ef998a1e281e
> prerequisite-patch-id: ef20898eb25a7ca1ea2d7b1d676f00b91b46d5f6
> prerequisite-patch-id: e0d0c0acbe4864a00451187ef7232dcaf10b2477
> prerequisite-patch-id: f6010b4a6e0b43ac837aea470b3b5e5f390ee3b2
Cheers,
Alejandro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-23 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 12:28 [PATCH] x86/ucode: Explain what microcode_set_module() does Andrew Cooper
2024-10-23 13:59 ` Alejandro Vallejo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.