[meta-multimedia][PATCH] pipewire: Add glib-2.0-native dep for bluez5

[meta-multimedia][PATCH] pipewire: Add glib-2.0-native dep for bluez5

[AmateurECE]

The SPA plugins for bluez depend on D-Bus bindings generated using
gdbus-codegen at build time. Some PACKAGECONFIG combinations appear to
pull this in accidentally. Add an explicit dependency to ensure that
it's in the sysroot when PACKAGECONFIG contains bluez5.

Signed-off-by: Ethan D. Twardy <ethan.twardy@gmail.com>

diff --git a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
index c8ac04d59..1c51fcc15 100644
--- a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
+++ b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
@@ -96,7 +96,7 @@ PACKAGECONFIG:class-target ??= " \
 # as being in conflict.
 PACKAGECONFIG[alsa] = "-Dalsa=enabled,-Dalsa=disabled,alsa-lib udev,,pipewire-alsa pipewire-alsa-card-profile"
 PACKAGECONFIG[avahi] = "-Davahi=enabled,-Davahi=disabled,avahi"
-PACKAGECONFIG[bluez] = "-Dbluez5=enabled,-Dbluez5=disabled,bluez5 sbc"
+PACKAGECONFIG[bluez] = "-Dbluez5=enabled,-Dbluez5=disabled,bluez5 sbc glib-2.0-native"
 PACKAGECONFIG[bluez-aac] = "-Dbluez5-codec-aac=enabled,-Dbluez5-codec-aac=disabled,fdk-aac"
 PACKAGECONFIG[bluez-opus] = "-Dbluez5-codec-opus=enabled,-Dbluez5-codec-opus=disabled,libopus"
 PACKAGECONFIG[bluez-lc3] = "-Dbluez5-codec-lc3=enabled,-Dbluez5-codec-lc3=disabled,liblc3"
-- 
2.45.2

Re: [oe] [meta-multimedia][PATCH] pipewire: Add glib-2.0-native dep for bluez5

[Khem Raj]

Thanks for the patch, it is not done on top of master it seems. Please
rebase it on master and resend if patch is needed for master
otherwise mark the release branch in subject prefix. This will help
route it correctly.

On Fri, Nov 29, 2024 at 11:57 AM AmateurECE via lists.openembedded.org
<ethan.twardy=gmail.com@lists.openembedded.org> wrote:
>
> The SPA plugins for bluez depend on D-Bus bindings generated using
> gdbus-codegen at build time. Some PACKAGECONFIG combinations appear to
> pull this in accidentally. Add an explicit dependency to ensure that
> it's in the sysroot when PACKAGECONFIG contains bluez5.
>
> Signed-off-by: Ethan D. Twardy <ethan.twardy@gmail.com>
>
> diff --git a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
> index c8ac04d59..1c51fcc15 100644
> --- a/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
> +++ b/meta-multimedia/recipes-multimedia/pipewire/pipewire_1.0.5.bb
> @@ -96,7 +96,7 @@ PACKAGECONFIG:class-target ??= " \
>  # as being in conflict.
>  PACKAGECONFIG[alsa] = "-Dalsa=enabled,-Dalsa=disabled,alsa-lib udev,,pipewire-alsa pipewire-alsa-card-profile"
>  PACKAGECONFIG[avahi] = "-Davahi=enabled,-Davahi=disabled,avahi"
> -PACKAGECONFIG[bluez] = "-Dbluez5=enabled,-Dbluez5=disabled,bluez5 sbc"
> +PACKAGECONFIG[bluez] = "-Dbluez5=enabled,-Dbluez5=disabled,bluez5 sbc glib-2.0-native"
>  PACKAGECONFIG[bluez-aac] = "-Dbluez5-codec-aac=enabled,-Dbluez5-codec-aac=disabled,fdk-aac"
>  PACKAGECONFIG[bluez-opus] = "-Dbluez5-codec-opus=enabled,-Dbluez5-codec-opus=disabled,libopus"
>  PACKAGECONFIG[bluez-lc3] = "-Dbluez5-codec-lc3=enabled,-Dbluez5-codec-lc3=disabled,liblc3"
> --
> 2.45.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#114119): https://lists.openembedded.org/g/openembedded-devel/message/114119
> Mute This Topic: https://lists.openembedded.org/mt/109839311/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe] [meta-multimedia][PATCH] pipewire: Add glib-2.0-native dep for bluez5

[AmateurECE]

On Fri Nov 29, 2024 at 5:28 PM CST, Khem Raj wrote:
> Thanks for the patch, it is not done on top of master it seems. Please
> rebase it on master and resend if patch is needed for master
> otherwise mark the release branch in subject prefix. This will help
> route it correctly.

Thanks for getting back to me, Khem! I will rebase onto master and
resend the patch shortly. Please forgive my question, I'm unfamiliar
with the OpenEmbedded development process: I'd like this change to be
applied to both master and the scarthgap branch, since I'm currently
basing my work on scarthgap. In that case, should I submit two patches,
one to be applied to master, and one to be applied to scarthgap (with
[scarthgap] in the subject line)?

Ethan

Re: [oe] [meta-multimedia][PATCH] pipewire: Add glib-2.0-native dep for bluez5

[Khem Raj]

On Tue, Dec 3, 2024 at 7:03 AM Ethan D. Twardy <ethan.twardy@gmail.com> wrote:
>
> On Fri Nov 29, 2024 at 5:28 PM CST, Khem Raj wrote:
> > Thanks for the patch, it is not done on top of master it seems. Please
> > rebase it on master and resend if patch is needed for master
> > otherwise mark the release branch in subject prefix. This will help
> > route it correctly.
>
> Thanks for getting back to me, Khem! I will rebase onto master and
> resend the patch shortly. Please forgive my question, I'm unfamiliar
> with the OpenEmbedded development process: I'd like this change to be
> applied to both master and the scarthgap branch, since I'm currently
> basing my work on scarthgap. In that case, should I submit two patches,
> one to be applied to master, and one to be applied to scarthgap (with
> [scarthgap] in the subject line)?

yes

>
> Ethan