Re: [PATCH] advice: suggest using subcommand "git config set"

["Bence Ferdinandy" <bence@ferdinandy.com>]

On Wed Dec 04, 2024 at 18:19, Justin Tobler <jltobler@gmail.com> wrote:
> On 24/12/04 02:08PM, Bence Ferdinandy wrote:
>> The advice message currently suggests using "git config advice..." to
>> disable advice messages, but since 00bbdde141f we have the "set"
>
> When referencing an existing commit, I think there is a preference to
> use the output of:
>
>   $ git show -s --format=reference 00bbdde141f
>   00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06)

Ack.

>
>> subcommand for config. Change the disable advice message to use the
>> subcommand instead. Change all uses of "git config advice" in the tests
>> to use the subcommand.
>
> Both "git config <config> <value>" and "git config set <config> <value>"
> are functionally the same operation. So the motivation for this seems to
> be to push/promote usage of the new "set" subcommand. I find the newer
> interface to be more intuitive and in line with modern command
> interfaces so updating the advice turn off messages here seems
> reasonable to me.

Yes, that was the motivation, I'll make that explicit in the commit message.

>
> There does appear to be other instances where the the advice turn off
> instructions are open-coded and thus retain the prior format. This does
> result in some inconsistency, which may not be a big deal, but maybe it
> would make sense to also adjust those sites as part of this series as
> also. Otherwise the changes in this patch look correct.

Fair point. Grepping the .c files yielded three more instances, I'll change
those as well.


Thanks,
Bence