From: Patrick Steinhardt <ps@pks.im>
To: Bence Ferdinandy <bence@ferdinandy.com>
Cc: git@vger.kernel.org, "Justin Tobler" <jltobler@gmail.com>,
"Heba Waly" <heba.waly@gmail.com>,
"Rubén Justo" <rjusto@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] advice: suggest using subcommand "git config set"
Date: Fri, 6 Dec 2024 09:57:08 +0100 [thread overview]
Message-ID: <Z1K8ZPF9eOqQYsqf@pks.im> (raw)
In-Reply-To: <20241205122225.1184215-1-bence@ferdinandy.com>
On Thu, Dec 05, 2024 at 01:21:58PM +0100, Bence Ferdinandy wrote:
> The advice message currently suggests using "git config advice..." to
> disable advice messages, but since
>
> 00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06)
>
> we have the "set" subcommand for config. Since using the subcommand is
> more in-line with the modern interface, any advice should be promoting
> its usage. Change the disable advice message to use the subcommand
> instead. Change all uses of "git config advice" in the tests to use the
> subcommand.
Thanks, this version looks good to me!
Patrick
next prev parent reply other threads:[~2024-12-06 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 13:08 [PATCH] advice: suggest using subcommand "git config set" Bence Ferdinandy
2024-12-04 17:19 ` Justin Tobler
2024-12-05 8:21 ` Bence Ferdinandy
2024-12-05 8:30 ` Patrick Steinhardt
2024-12-05 12:21 ` [PATCH v2] " Bence Ferdinandy
2024-12-06 8:57 ` Patrick Steinhardt [this message]
2024-12-08 8:08 ` Rubén Justo
2024-12-08 8:12 ` [PATCH 1/3] advice: enhance `detach_advice()` to `detach_advice_if_enabled()` Rubén Justo
2024-12-08 8:12 ` [PATCH 2/3] commit: use `advise_if_enabled()` in `read_graft_file()` Rubén Justo
2024-12-08 8:12 ` [PATCH 3/3] object-name: advice to avoid refs that resemble hashes Rubén Justo
2024-12-09 11:21 ` [PATCH v2] advice: suggest using subcommand "git config set" Bence Ferdinandy
2024-12-09 14:46 ` Bence Ferdinandy
2024-12-09 20:35 ` Rubén Justo
2024-12-11 8:52 ` Bence Ferdinandy
2024-12-11 18:00 ` Rubén Justo
2024-12-06 2:23 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1K8ZPF9eOqQYsqf@pks.im \
--to=ps@pks.im \
--cc=bence@ferdinandy.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
--cc=jltobler@gmail.com \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.