All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Diederik de Haas" <didi.debian@cknow.org>
To: "FUKAUMI Naoki" <naoki@radxa.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>, <heiko@sntech.de>
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<dsimic@manjaro.org>, <devicetree@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C
Date: Mon, 16 Dec 2024 17:11:31 +0100	[thread overview]
Message-ID: <D6D997JACT2Y.294J06IIIVEY7@cknow.org> (raw)
In-Reply-To: <E3B9E510C4F8D95A+7a184f12-902b-47ea-894c-4552e189d19b@radxa.com>


[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]

On Mon Dec 16, 2024 at 3:38 PM CET, FUKAUMI Naoki wrote:
> On 12/16/24 23:27, Krzysztof Kozlowski wrote:
> > On 16/12/2024 15:19, FUKAUMI Naoki wrote:
> >> On 12/16/24 22:56, Krzysztof Kozlowski wrote:
> >>> On 16/12/2024 14:48, FUKAUMI Naoki wrote:
> >>>> On 12/16/24 22:37, Krzysztof Kozlowski wrote:
> >>>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote:
> >>>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change.
> >>>>>
> >>>>> No, generic name is fan.
> >>>>
> >>>>     https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/
> >>>>
> >>> And? That's incorrect advice.  There is no such device as "pwm-fan".
> >>> There is a "fan" and whether it is pwm or gpio it does not matter.
> >>>
> >>> See DT spec and generic names recommendation.
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67
> >>
> >> Is it wrong?
> > Yes.

There's an(other) issue with the binding:
line 91 references `&fan0` while it isn't defined (in the binding
example)

Cheers,
  Diederik

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Diederik de Haas" <didi.debian@cknow.org>
To: "FUKAUMI Naoki" <naoki@radxa.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>, <heiko@sntech.de>
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<dsimic@manjaro.org>, <devicetree@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C
Date: Mon, 16 Dec 2024 17:11:31 +0100	[thread overview]
Message-ID: <D6D997JACT2Y.294J06IIIVEY7@cknow.org> (raw)
In-Reply-To: <E3B9E510C4F8D95A+7a184f12-902b-47ea-894c-4552e189d19b@radxa.com>

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Mon Dec 16, 2024 at 3:38 PM CET, FUKAUMI Naoki wrote:
> On 12/16/24 23:27, Krzysztof Kozlowski wrote:
> > On 16/12/2024 15:19, FUKAUMI Naoki wrote:
> >> On 12/16/24 22:56, Krzysztof Kozlowski wrote:
> >>> On 16/12/2024 14:48, FUKAUMI Naoki wrote:
> >>>> On 12/16/24 22:37, Krzysztof Kozlowski wrote:
> >>>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote:
> >>>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change.
> >>>>>
> >>>>> No, generic name is fan.
> >>>>
> >>>>     https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/
> >>>>
> >>> And? That's incorrect advice.  There is no such device as "pwm-fan".
> >>> There is a "fan" and whether it is pwm or gpio it does not matter.
> >>>
> >>> See DT spec and generic names recommendation.
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67
> >>
> >> Is it wrong?
> > Yes.

There's an(other) issue with the binding:
line 91 references `&fan0` while it isn't defined (in the binding
example)

Cheers,
  Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2024-12-16 16:11 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 11:30 [PATCH v5 00/12] arm64: dts: rockchip: Refine dts for Radxa ROCK 5C FUKAUMI Naoki
2024-12-16 11:30 ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 01/12] arm64: dts: rockchip: Change function name for blue LED " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 12:43   ` Dragan Simic
2024-12-16 12:43     ` Dragan Simic
2024-12-16 13:42     ` Krzysztof Kozlowski
2024-12-16 13:42       ` Krzysztof Kozlowski
2024-12-16 15:21       ` Dragan Simic
2024-12-16 15:21         ` Dragan Simic
2024-12-16 13:37   ` Krzysztof Kozlowski
2024-12-16 13:37     ` Krzysztof Kozlowski
2024-12-16 13:48     ` FUKAUMI Naoki
2024-12-16 13:48       ` FUKAUMI Naoki
2024-12-16 13:56       ` Krzysztof Kozlowski
2024-12-16 13:56         ` Krzysztof Kozlowski
2024-12-16 14:19         ` FUKAUMI Naoki
2024-12-16 14:19           ` FUKAUMI Naoki
2024-12-16 14:27           ` Krzysztof Kozlowski
2024-12-16 14:27             ` Krzysztof Kozlowski
2024-12-16 14:38             ` FUKAUMI Naoki
2024-12-16 14:38               ` FUKAUMI Naoki
2024-12-16 15:26               ` Dragan Simic
2024-12-16 15:26                 ` Dragan Simic
2024-12-16 16:11               ` Diederik de Haas [this message]
2024-12-16 16:11                 ` Diederik de Haas
2024-12-16 11:30 ` [PATCH v5 03/12] arm64: dts: rockchip: Use a longer PWM period for the fan on " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 12:43   ` Dragan Simic
2024-12-16 12:43     ` Dragan Simic
2024-12-16 11:30 ` [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 13:38   ` Krzysztof Kozlowski
2024-12-16 13:38     ` Krzysztof Kozlowski
2024-12-16 13:55     ` FUKAUMI Naoki
2024-12-16 13:55       ` FUKAUMI Naoki
2024-12-17  1:11     ` FUKAUMI Naoki
2024-12-17  1:11       ` FUKAUMI Naoki
2024-12-20  6:51       ` FUKAUMI Naoki
2024-12-20  6:51         ` FUKAUMI Naoki
2024-12-21 20:15         ` Krzysztof Kozlowski
2024-12-21 20:15           ` Krzysztof Kozlowski
2024-12-22  3:18           ` FUKAUMI Naoki
2024-12-22  3:18             ` FUKAUMI Naoki
2024-12-22  6:27             ` Krzysztof Kozlowski
2024-12-22  6:27               ` Krzysztof Kozlowski
2024-12-22 17:46               ` Dragan Simic
2024-12-22 17:46                 ` Dragan Simic
2024-12-16 11:30 ` [PATCH v5 05/12] arm64: dts: rockchip: Add properties " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 06/12] arm64: dts: rockchip: Remove RTC and related node " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 07/12] arm64: dts: rockchip: Separate pinctrl for vcc_5v0 " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 08/12] arm64: dts: rockchip: Add cd-gpios for sdmmc " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 09/12] arm64: dts: rockchip: Fix pmic dcdc-reg7 regulator-name " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 10/12] arm64: dts: rockchip: Fix pmic dcdc-reg10 label " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 13:40   ` Krzysztof Kozlowski
2024-12-16 13:40     ` Krzysztof Kozlowski
2024-12-17  0:47     ` FUKAUMI Naoki
2024-12-17  0:47       ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki
2024-12-16 13:41   ` Krzysztof Kozlowski
2024-12-16 13:41     ` Krzysztof Kozlowski
2024-12-17  0:43     ` FUKAUMI Naoki
2024-12-17  0:43       ` FUKAUMI Naoki
2024-12-17  6:24       ` Krzysztof Kozlowski
2024-12-17  6:24         ` Krzysztof Kozlowski
2024-12-17  7:16         ` FUKAUMI Naoki
2024-12-17  7:16           ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 12/12] arm64: dts: rockchip: Sort nodes " FUKAUMI Naoki
2024-12-16 11:30   ` FUKAUMI Naoki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6D997JACT2Y.294J06IIIVEY7@cknow.org \
    --to=didi.debian@cknow.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.