[PATCH v2 0/3] Cover systemd.bbclass and devtool ide-sdk changes

[PATCH v2 0/3] Cover systemd.bbclass and devtool ide-sdk changes

[Adrian Freihofer]

Diff to v1:
- rebased on todays master branch
- Folowing all the suggestions from Antonin
  https://lists.yoctoproject.org/g/docs/message/6034
  Thank you for the review!

Adrian Freihofer (3):
  migration-guides: systemd.bbclass do not add Also services for 5.2
  sdk-manual: extensible.rst: update devtool ide-sdk
  sdk-manual: extensible.rst: remove confusing post-install-logging

 .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
 documentation/sdk-manual/extensible.rst       |  8 ++++----
 2 files changed, 23 insertions(+), 4 deletions(-)

-- 
2.47.1

[PATCH v2 1/3] migration-guides: systemd.bbclass do not add Also services for 5.2

[Adrian Freihofer]

Covers the chagnes introduced by commit
https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
index cb70e19da..b18ae30d9 100644
--- a/documentation/migration-guides/migration-5.2.rst
+++ b/documentation/migration-guides/migration-5.2.rst
@@ -74,6 +74,25 @@ systemd changes
    As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
    :term:`PACKAGECONFIG` option as it is now implied by default.
 
+-  ``systemd.bbclass``: If a systemd service file had referred to other service
+   files by starting them as
+   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
+   the other service files were automatically added to the :term:`FILES` variable of
+   the same package. Example: 
+
+   a.service contains::
+
+      [Install]
+      Also=b.service
+
+   If a.service is packaged in package A, b.service is automatically packaged
+   into package A as well. This happens even if b.service is explicitly added
+   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.
+   This prevents such services from being packaged into different packages.
+   Therefore, this automatic behavior has been removed for service files (but
+   not for socket files).
+   Now all service files must be explicitly added to :term:`FILES`.
+
 Recipe changes
 ~~~~~~~~~~~~~~
 
-- 
2.47.1

Re: [docs] [PATCH v2 1/3] migration-guides: systemd.bbclass do not add Also services for 5.2

[Antonin Godard]

Hi Adrian,

On Thu Jan 9, 2025 at 11:17 PM CET, Adrian Freihofer via lists.yoctoproject.org wrote:
> Covers the chagnes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da..b18ae30d9 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,25 @@ systemd changes
>     As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>     :term:`PACKAGECONFIG` option as it is now implied by default.
>  
> +-  ``systemd.bbclass``: If a systemd service file had referred to other service
> +   files by starting them as
> +   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
> +   the other service files were automatically added to the :term:`FILES` variable of
> +   the same package. Example: 
> +
> +   a.service contains::
> +
> +      [Install]
> +      Also=b.service
> +
> +   If a.service is packaged in package A, b.service is automatically packaged
> +   into package A as well. This happens even if b.service is explicitly added
> +   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.
> +   This prevents such services from being packaged into different packages.
> +   Therefore, this automatic behavior has been removed for service files (but
> +   not for socket files).
> +   Now all service files must be explicitly added to :term:`FILES`.
> +
>  Recipe changes
>  ~~~~~~~~~~~~~~
>  

Reviewed-by: Antonin Godard <antonin.godard@bootlin.com>

Thank you!
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] [PATCH v2 1/3] migration-guides: systemd.bbclass do not add Also services for 5.2

[Quentin Schulz]

Hi Adrian,

On 1/9/25 11:17 PM, Adrian Freihofer via lists.yoctoproject.org wrote:
> Covers the chagnes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>   .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da..b18ae30d9 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,25 @@ systemd changes
>      As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>      :term:`PACKAGECONFIG` option as it is now implied by default.
>   
> +-  ``systemd.bbclass``: If a systemd service file had referred to other service

``systemd`` ?

> +   files by starting them as
> +   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
> +   the other service files were automatically added to the :term:`FILES` variable of
> +   the same package. Example:
> +
> +   a.service contains::
> +
> +      [Install]
> +      Also=b.service
> +
> +   If a.service is packaged in package A, b.service is automatically packaged
> +   into package A as well. This happens even if b.service is explicitly added
> +   to package B using FILES and :term:`SYSTEMD_SERVICE` variables.

s/FILES/:term:`FILES`/

For all the above, probably ``a.service``, ``A``, ``b.service``, ``B``, 
for words that aren't English.

Looks good otherwise.

Cheers,
Quentin

[PATCH v2 2/3] sdk-manual: extensible.rst: update devtool ide-sdk

[Adrian Freihofer]

Replace
  devtool ide-sdk --debug-build-config
by
  devtool modify --debug-build

This change was introduced with commit
https://git.yoctoproject.org/poky/commit/?id=1f7eb26c947dde14698ae6e2ab88f0637027f4cb

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 documentation/sdk-manual/extensible.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/documentation/sdk-manual/extensible.rst b/documentation/sdk-manual/extensible.rst
index 9a50d7fc5..3733997fa 100644
--- a/documentation/sdk-manual/extensible.rst
+++ b/documentation/sdk-manual/extensible.rst
@@ -669,7 +669,8 @@ The extensible SDK supports two different development modes.
       IMAGE_INSTALL:append = " my-recipe"
 
    Assuming the BitBake environment is set up correctly and a workspace has
-   been created for the recipe using ``devtool modify my-recipe``, the
+   been created for the recipe using ``devtool modify my-recipe`` or probably
+   even better by using ``devtool modify my-recipe --debug-build``, the
    following command can create the SDK and the configuration for VSCode in
    the recipe workspace::
 
@@ -786,8 +787,8 @@ The extensible SDK supports two different development modes.
    .. code-block:: sh
 
       # Create the SDK
-      devtool modify cmake-example
-      devtool ide-sdk cmake-example core-image-minimal -c --debug-build-config --ide=none
+      devtool modify cmake-example --debug-build
+      devtool ide-sdk cmake-example core-image-minimal -c --ide=none
 
       # Install the firmware on a target device or start QEMU
       runqemu
-- 
2.47.1

[PATCH v2 3/3] sdk-manual: extensible.rst: remove confusing post-install-logging

[Adrian Freihofer]

This is a fix for 22dc5b3be3b1fbdb9447999b71f79db055271826, which has
completely replaced debug-tweaks. But in the context of devtool ide-sdk
and the comment in the example, the post-install-logging-image feature
doesn't really make much sense. Therefore, remove it.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 documentation/sdk-manual/extensible.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/documentation/sdk-manual/extensible.rst b/documentation/sdk-manual/extensible.rst
index 3733997fa..1cb1bb47c 100644
--- a/documentation/sdk-manual/extensible.rst
+++ b/documentation/sdk-manual/extensible.rst
@@ -658,7 +658,6 @@ The extensible SDK supports two different development modes.
          allow-empty-password \
          allow-root-login \
          empty-root-password \
-         post-install-logging \
       "
 
       # Remote debugging needs gdbserver on the target device
-- 
2.47.1