From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
<ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: remove peer extra rssi update
Date: Wed, 29 Jan 2025 10:18:32 +0100 [thread overview]
Message-ID: <D7EG0ZAD9USJ.2UCEVJJNB45LF@gmail.com> (raw)
In-Reply-To: <dd5d8193-3b35-4eac-b551-4dce5e82c3f9@oss.qualcomm.com>
On Wed Jan 29, 2025 at 1:08 AM CET, Jeff Johnson wrote:
> On 1/28/2025 2:29 PM, Jeff Johnson wrote:
>> On 1/17/2025 10:19 AM, Nicolas Escande wrote:
>>> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an
>>
>> I'll fixup this reference to address the checkpatch error:
>> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")'
>> total: 1 errors, 0 warnings, 0 checks, 8 lines checked
>>
>>> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
>>> when it added the average rssi support. So lets keeps only one by removing
>>> the legacy assignment so the two statements about rssi stay next to each
>>> other. Compile tested only.
>
> I actually made three fixups, please check:
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=7946ec554fbea5db9a3aedb7087f0eb9e3749abc
>
> 1) commit reference
> 2) add () to function name
> 3) lets => let's
Thanks, it looks perfect.
next prev parent reply other threads:[~2025-01-29 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 18:19 [PATCH] wifi: ath11k: remove peer extra rssi update Nicolas Escande
2025-01-18 10:39 ` Vasanthakumar Thiagarajan
2025-01-28 22:29 ` Jeff Johnson
2025-01-29 0:08 ` Jeff Johnson
2025-01-29 9:18 ` Nicolas Escande [this message]
2025-01-29 9:24 ` Nicolas Escande
2025-01-30 17:44 ` Jeff Johnson
2025-01-29 17:03 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7EG0ZAD9USJ.2UCEVJJNB45LF@gmail.com \
--to=nico.escande@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.