All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Nicolas Escande <nico.escande@gmail.com>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath11k: remove peer extra rssi update
Date: Tue, 28 Jan 2025 14:29:24 -0800	[thread overview]
Message-ID: <d5eda793-c7e9-453f-9dbc-07e5df73c47d@oss.qualcomm.com> (raw)
In-Reply-To: <20250117181953.3375273-1-nico.escande@gmail.com>

On 1/17/2025 10:19 AM, Nicolas Escande wrote:
> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an

I'll fixup this reference to address the checkpatch error:
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")'
total: 1 errors, 0 warnings, 0 checks, 8 lines checked

> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
> when it added the average rssi support. So lets keeps only one by removing
> the legacy assignment so the two statements about rssi stay next to each
> other. Compile tested only.
> 
> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
> ---
>  drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 029ecf51c9efd..24774cba9823b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2831,8 +2831,6 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta,
>  	rx_stats->dcm_count += ppdu_info->dcm;
>  	rx_stats->ru_alloc_cnt[ppdu_info->ru_alloc] += num_msdu;
>  
> -	arsta->rssi_comb = ppdu_info->rssi_comb;
> -
>  	BUILD_BUG_ON(ARRAY_SIZE(arsta->chain_signal) >
>  			     ARRAY_SIZE(ppdu_info->rssi_chain_pri20));
>  



  parent reply	other threads:[~2025-01-28 22:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 18:19 [PATCH] wifi: ath11k: remove peer extra rssi update Nicolas Escande
2025-01-18 10:39 ` Vasanthakumar Thiagarajan
2025-01-28 22:29 ` Jeff Johnson [this message]
2025-01-29  0:08   ` Jeff Johnson
2025-01-29  9:18     ` Nicolas Escande
2025-01-29  9:24   ` Nicolas Escande
2025-01-30 17:44     ` Jeff Johnson
2025-01-29 17:03 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5eda793-c7e9-453f-9dbc-07e5df73c47d@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nico.escande@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.