* [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description
@ 2025-01-31 11:53 Marc Hartmayer
2025-02-04 10:25 ` Nico Boehr
2025-03-05 15:15 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Marc Hartmayer @ 2025-01-31 11:53 UTC (permalink / raw)
To: kvm
Cc: Janosch Frank, Nico Boehr, Thomas Huth, Alex Bennée,
Andrew Jones, Paolo Bonzini
Add max line length setting for commit messages and branch descriptions to
the Editorconfig configuration. Use herefor the same value as used by
checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.
[1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
[2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
.editorconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.editorconfig b/.editorconfig
index 46d4ac64f897..03bb16cb9442 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -13,3 +13,6 @@ insert_final_newline = true
charset = utf-8
indent_style = tab
indent_size = 8
+
+[{COMMIT_EDITMSG,EDIT_DESCRIPTION}]
+max_line_length = 75
base-commit: 2e66bb4b9423970ceb6ea195bd8697733bcd9071
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description
2025-01-31 11:53 [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description Marc Hartmayer
@ 2025-02-04 10:25 ` Nico Boehr
2025-03-05 15:15 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Nico Boehr @ 2025-02-04 10:25 UTC (permalink / raw)
To: Marc Hartmayer, kvm
Cc: Janosch Frank, Thomas Huth, Alex Bennée, Andrew Jones,
Paolo Bonzini
On Fri Jan 31, 2025 at 12:53 PM CET, Marc Hartmayer wrote:
> Add max line length setting for commit messages and branch descriptions to
> the Editorconfig configuration. Use herefor the same value as used by
> checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.
>
> [1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
> [2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
I don't use editorconfig, but it seems like a valuable thing to do, hence:
Acked-by: Nico Boehr <nrb@linux.ibm.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description
2025-01-31 11:53 [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description Marc Hartmayer
2025-02-04 10:25 ` Nico Boehr
@ 2025-03-05 15:15 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2025-03-05 15:15 UTC (permalink / raw)
To: Marc Hartmayer, kvm
Cc: Janosch Frank, Nico Boehr, Alex Bennée, Andrew Jones,
Paolo Bonzini
On 31/01/2025 12.53, Marc Hartmayer wrote:
> Add max line length setting for commit messages and branch descriptions to
> the Editorconfig configuration. Use herefor the same value as used by
> checkpatch [1]. See [2] for details about the file 'COMMIT_EDITMSG'.
>
> [1] https://github.com/torvalds/linux/blob/69e858e0b8b2ea07759e995aa383e8780d9d140c/scripts/checkpatch.pl#L3270
> [2] https://git-scm.com/docs/git-commit/2.46.1#Documentation/git-commit.txt-codeGITDIRCOMMITEDITMSGcode
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
> .editorconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.editorconfig b/.editorconfig
> index 46d4ac64f897..03bb16cb9442 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -13,3 +13,6 @@ insert_final_newline = true
> charset = utf-8
> indent_style = tab
> indent_size = 8
> +
> +[{COMMIT_EDITMSG,EDIT_DESCRIPTION}]
> +max_line_length = 75
Thanks, applied now!
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-05 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-31 11:53 [kvm-unit-tests PATCH v1] editorconfig: Add max line length setting for commit message and branch description Marc Hartmayer
2025-02-04 10:25 ` Nico Boehr
2025-03-05 15:15 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.